Add husky pre-push check (#4)

Add husky dependency & configuration.
Since we automatically cut a new release when one is detected in a commit, we need to run the tests before pushing, to ensure that our rules are still applied as expected.
Add notes to README as to why we do not have any other integrations.
Add CODEOWNERS & contributing guidelines.

Author: skye2k2

.github/CONTRIBUTING.md

@@ -0,0 +1,11 @@
+# Contributing
+
+Looking to contribute to the TreeWeb codebase? You've come to the right place! We welcome pull requests, issues, feedback, etc., and have a few guidelines for contributions:
+
+### When Contributing
+
+- **Include tests that test the range of behavior that changes.**
+- Update any associated documentation affected by your change.
+- Ensure your pull request description accurately describes the changes you are proposing. See [short reason](https://twitter.com/dzaporozhets/status/870268536404533249) and [long reason](https://medium.com/square-corner-blog/how-square-writes-commit-messages-8e92fcbf77c9).
+- If your PR fixes a bug, make sure the issue includes clear steps to reproduce the bug so the fix can be easily tested.
+- Increment package.json version (used to automatically tag a new release).

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,16 @@
+A few sentences describing the overall goals of the pull request's commits. Reference any issues/JIRAs/dependent PR's. Should **never** be empty. A commit subject line should always be able to complete the following sentence:
+
+> If applied, this commit will **_your present-tense subject line here_**.
+
+Review: [CONTRIBUTING.md](/.github/CONTRIBUTING.md)
+
+## Changes
+- Summarize
+- Your
+- Changes
+
+## To-Dos
+- [ ] Run tests (part of pre-push hook)
+- [ ] Update demo and tests, if linting configuration is being changed
+- [ ] Update documentation & README
+- [ ] Increment package.json version

CODEOWNERS

@@ -0,0 +1,8 @@
+#########################################################################################
+# Code Ownership for fs-demo 
+#   All files owned by tw-gold
+#
+# See https://help.github.com/en/articles/about-code-owners for information on how to use
+#########################################################################################
+
+*   @fs-webdev/tw-gold

README.md

@@ -41,16 +41,36 @@ Utilizes the following plugins:
   plugins: [
     'eslint-plugin-bestpractices',
     'eslint-plugin-deprecate',
-    'eslint-plugin-sonarjs'
+    'eslint-plugin-no-only-tests',
+    'eslint-plugin-no-skip-tests',
+    'eslint-plugin-promise',
+    'eslint-plugin-sonarjs',
+    'eslint-plugin-test-selectors'
+  ]
+}</code></pre>
+
+ 1. Add a `.codeclimate.eslintrc.js`
+ <pre><code>module.exports = {
+  extends: [
+    './eslint-config-frontier.js', // or '@fs/eslint-config-frontier-react'
+    './eslint-config-tree.js'
   ]
 }</code></pre>
 
  1. Add both `tree` and the frontier eslint configuration of your choice as Code Climate `prepare` resources (see: [extended eslint docs](https://www.familysearch.org/frontier/legacy/ui-components/eslint-config-frontier/)).
 
+ 1. Set this simplified eslint configuration as the chosen config in your Code Climate's `plugins`: `eslint`: `config`: `config`.
+
  1. Enjoy.
 
 ## Testing/Updating:
 
 Occasionally, there may be an update which breaks a rule in particular or linting in general. To this end, when running `npm test`, we output the current linting results to a text file, clean it up a little, and employ ava to run a snapshot comparison unit test to determine if our linting output has changed from the previous run.
 
 If there has been a change (say you added a new rule, or there is a new valid violation triggered), you can update the snapshot via `npm run test:update`.
+
+## Notes
+
+- Because this is a public repository, there are complications in adding references to private services and communications channels, so there is no Travis CI build and no Code Climate integration.
+- Coverage reporting ends up reporting on `lint-output.js`, instead of `index.js`, and so is also not used.
+- As noted in the `Testing/Updating` section, the only validation we do is to run linting against a file with a set of known failures. So we make sure to run `npm test` via a pre-push hook.

index.js

@@ -49,7 +49,7 @@ module.exports = {
   parser: 'babel-eslint',
   /**
    * @property {object} plugins - Tree additional linter plugins.
-   * @note - Code Climate does not support bestpractices, deprecate, no-only-tests, no-skip-tests, sonarjs, and test-selectors, and breaks if they are present. You will need to add these plugins individually in your .eslintrc.js file.
+   * @note - Code Climate does not yet support bestpractices, deprecate, no-only-tests, no-skip-tests, sonarjs, and test-selectors, and breaks if they are present. You will need to add these plugins individually in your .eslintrc.js file. The first time you add a file, Code Climate will complain about not being able to find the definitions for these extra rules once for every new file. Obnoxious, but the best we have, for now.
    */
   plugins: [
     // 'eslint-plugin-bestpractices',

package.json

@@ -43,7 +43,13 @@
   "devDependencies": {
     "ava": "^2.4.0",
     "eslint-config-frontier": "github:fs-webdev/eslint-config-frontier",
-    "file-manager-js": "^3.1.6"
+    "file-manager-js": "^3.1.6",
+    "husky": "^3.1.0"
+  },
+  "husky": {
+    "hooks": {
+      "pre-push": "npm test"
+    }
   },
   "resolutions": {
     "eslint": "^6"
@@ -55,6 +61,7 @@
     "lint:report": "eslint --ignore-pattern '.*' '**/*.html' '**/*.js' '**/*.json' '**/*.html' --format html --output-file ./reports/linter/lintresults.html & eslint --ignore-pattern '.*' '**/*.js' '**/*.json' --format json --output-file ./reports/linter/lintresults.json",
     "lint:snapshot": "eslint --ignore-pattern '.*' '**/*.html' '**/*.js' '**/*.json' --no-color --output-file ./demo/test/snapshots/new-lint-results.txt; npm run test:format",
     "preinstall": "git config --global url.https://github.com/.insteadOf git://github.com/",
+    "postinstall": "npm rebuild husky",
     "test": "npm run lint:snapshot; ava",
     "test:format": "sed -i '' 's|^.*eslint-config-tree/demo/||g' demo/test/snapshots/new-lint-results.txt",
     "test:update": "npm run lint:snapshot; ava --update-snapshots"