Add eslint-plugin-bestpractices dependency.

New warning: any time eslint-disable is used.
Release version 1.0.14.

Author: skye2k2

.eslintrc.js

@@ -7,6 +7,7 @@ module.exports = {
   ],
   plugins: [
     // Enable plugins that are not natively supported by Code Climate. Otherwise results in build errors.
+    'eslint-plugin-bestpractices',
     'eslint-plugin-deprecate',
     'eslint-plugin-sonarjs'
   ],

README.md

@@ -4,6 +4,7 @@ This is a shared configuration for all Tree repositories. Contains overrides and
 
 Utilizes the following plugins:
 
+ - [eslint-plugin-bestpractices](https://github.com/skye2k2/eslint-plugin-bestpractices)
  - [eslint-plugin-deprecate](https://github.com/AlexMost/eslint-plugin-deprecate)
  - [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html)
  - [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import)
@@ -32,6 +33,7 @@ Utilizes the following plugins:
     'tree'
   ],
   plugins: [
+    'eslint-plugin-bestpractices',
     'eslint-plugin-deprecate',
     'eslint-plugin-sonarjs'
   ]

demo/example-eslint-results.png

@@ -1,5 +1,10 @@
 /* Example of a broken JSON file that should trigger the additional rules contained in ./index.js */
 
+/*
+ * Since developers have the ability to disable linting in-line, we keep track of the times where this is done.
+ */
+// eslint-disable-next
+
 // fixMe: Actually make this work
 // todo: Add documentation
 // Hack: Note that these work, regardless of case

demo/example.js

@@ -43,6 +43,7 @@ module.exports = {
    * @note - Code Climate does not support deprecate and sonarjs, and breaks if they are present. You will need to add these plugins individually in your .eslintrc.js file.
    */
   plugins: [
+    // 'eslint-plugin-bestpractices',
     // 'eslint-plugin-deprecate',
     'eslint-plugin-html',
     'eslint-plugin-jsdoc',
@@ -92,6 +93,8 @@ module.exports = {
     'object-curly-spacing': 'off',
     'semi': ['error', 'always'],
 
+    'bestpractices/no-eslint-disable': 'warn',
+
     'sonarjs/cognitive-complexity': 'warn',
     'sonarjs/max-switch-cases': 'warn',
     'sonarjs/no-all-duplicated-branches': 'warn',

index.js

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-tree",
-  "version": "1.0.13",
+  "version": "1.0.14",
   "description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
   "main": "index.js",
   "repository": {
@@ -21,6 +21,7 @@
     "eslint": "^5",
     "eslint-config-standard": "^12",
     "eslint-config-standard-react": "^7",
+    "eslint-plugin-bestpractices": "git+https://github.com/skye2k2/eslint-plugin-bestpractices.git",
     "eslint-plugin-deprecate": "^0.5",
     "eslint-plugin-html": "^4",
     "eslint-plugin-import": "^2",