Run analyzers for all projects

Author: nojaf

.config/dotnet-tools.json

@@ -9,7 +9,7 @@
       ]
     },
     "fsharp-analyzers": {
-      "version": "0.26.0",
+      "version": "0.32.1",
       "commands": [
         "fsharp-analyzers"
       ]

.github/workflows/pull-requests.yml

@@ -34,4 +34,4 @@ jobs:
       uses: github/codeql-action/upload-sarif@v3
       if: matrix.os == 'ubuntu-latest'
       with:
-        sarif_file: ./reports
+        sarif_file: ./analysis.sarif

.gitignore

@@ -50,4 +50,4 @@ tests/FSharp.Literate.Tests/output2/
 tests/FSharp.Literate.Tests/previous-next-output/
 
 # Analyzer
-reports/
+analysis.sarif

Directory.Packages.props

@@ -26,8 +26,7 @@
     <PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" />
-    <PackageVersion Include="FSharp.Analyzers.Build" Version="0.3.0" />
-    <PackageVersion Include="G-Research.FSharp.Analyzers" Version="0.10.0" />
-    <PackageVersion Include="Ionide.Analyzers" Version="0.11.0" />
+    <PackageVersion Include="G-Research.FSharp.Analyzers" Version="0.18.0" />
+    <PackageVersion Include="Ionide.Analyzers" Version="0.14.7" />
   </ItemGroup>
 </Project>

Directory.Solution.targets

@@ -1,9 +1,26 @@
 <Project>
-    <ItemGroup>
-        <ProjectsToAnalyze Include="src/**/*.fsproj" />
-    </ItemGroup>
+    <!-- Import the NuGet props file to get access to Pkg* variables -->
+    <Import Project="src/FSharp.Formatting/obj/FSharp.Formatting.fsproj.nuget.g.props" Condition="Exists('src/FSharp.Formatting/obj/FSharp.Formatting.fsproj.nuget.g.props')" />
 
-    <Target Name="AnalyzeSolution">
-        <MSBuild Projects="@(ProjectsToAnalyze)" Targets="AnalyzeFSharpProject" />
-    </Target>
-</Project>
+  <ItemGroup>
+    <ProjectsToAnalyze Include="src/**/*.fsproj" />
+  </ItemGroup>
+
+  <Target Name="AnalyzeSolution" Condition="Exists('src/FSharp.Formatting/obj/FSharp.Formatting.fsproj.nuget.g.props')">
+    <PropertyGroup>
+        <CodeRoot>$(SolutionDir)</CodeRoot>
+        <FSharpAnalyzersOtherFlags>--analyzers-path &quot;$(PkgG-Research_FSharp_Analyzers)/analyzers/dotnet/fs&quot;</FSharpAnalyzersOtherFlags>
+        <FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --analyzers-path &quot;$(PkgIonide_Analyzers)/analyzers/dotnet/fs&quot;</FSharpAnalyzersOtherFlags>
+        <FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --exclude-analyzers PartialAppAnalyzer ReturnStructPartialActivePatternAnalyzer -c Release</FSharpAnalyzersOtherFlags>
+        <FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --code-root $(CodeRoot)</FSharpAnalyzersOtherFlags>
+        <FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --report &quot;$(CodeRoot)/analysis.sarif&quot;</FSharpAnalyzersOtherFlags>
+    </PropertyGroup>
+  <Delete Files="$(SolutionDir)/analysis.sarif" Condition="Exists('$(SolutionDir)/analysis.sarif')" />
+
+    <!-- Execute fsharp-analyzers with all projects in a single process -->
+    <Exec
+      Command="dotnet fsharp-analyzers $(FSharpAnalyzersOtherFlags) @(ProjectsToAnalyze->'--project &quot;%(FullPath)&quot;', ' ')"
+      ContinueOnError="true"
+    />
+  </Target>
+</Project>

src/Directory.Build.props

@@ -1,10 +1,6 @@
 <Project>
     <Import Project="../Directory.Build.props" />
     <ItemGroup>
-        <PackageReference Include="FSharp.Analyzers.Build">
-            <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>build</IncludeAssets>
-        </PackageReference>
         <PackageReference Include="G-Research.FSharp.Analyzers">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>analyzers</IncludeAssets>