From e68bd813c3d034814a97349df450ae45ff589068 Mon Sep 17 00:00:00 2001 From: Matt Peel Date: Wed, 10 Sep 2025 01:27:47 +1200 Subject: [PATCH 1/3] fix: Add googlemapfield class name so JS actually binds to the fields correctly, but not to the field holder --- src/GoogleMapField.php | 2 ++ templates/BetterBrief/GoogleMapField_holder.ss | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/GoogleMapField.php b/src/GoogleMapField.php index f385e57..927921f 100644 --- a/src/GoogleMapField.php +++ b/src/GoogleMapField.php @@ -79,6 +79,8 @@ public function __construct($name, $title = null, $value = null, $data = [], $o $this->defaultValues = $data; } + $this->addExtraClass('googlemapfield'); + $this->setupChildren(); } diff --git a/templates/BetterBrief/GoogleMapField_holder.ss b/templates/BetterBrief/GoogleMapField_holder.ss index df878d9..f746802 100644 --- a/templates/BetterBrief/GoogleMapField_holder.ss +++ b/templates/BetterBrief/GoogleMapField_holder.ss @@ -1,4 +1,4 @@ -
+
<% if $Title %><% end_if %>
$Field From ff91a85a415e119f14fd6d1834c641e58dda2da7 Mon Sep 17 00:00:00 2001 From: Matt Peel Date: Wed, 10 Sep 2025 01:42:33 +1200 Subject: [PATCH 2/3] fix: Don't look for visible fields when race conditions prevent it being visible sometimes --- client/js/GoogleMapField.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/js/GoogleMapField.js b/client/js/GoogleMapField.js index f99992a..84bd56c 100644 --- a/client/js/GoogleMapField.js +++ b/client/js/GoogleMapField.js @@ -232,7 +232,7 @@ window.googlemapfieldInit = function () { }; function init() { - var mapFields = $(".googlemapfield:visible").gmapfield(); + var mapFields = $(".googlemapfield").gmapfield(); mapFields.each(initField); } From 686b035960222336e3d4b76fbc5cb4077bacb41c Mon Sep 17 00:00:00 2001 From: Matt Peel Date: Sun, 14 Sep 2025 22:28:32 +1200 Subject: [PATCH 3/3] fix: Set values rather than passing the entire data set in (when it's not expected) --- src/GoogleMapField.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/GoogleMapField.php b/src/GoogleMapField.php index 927921f..19c5c80 100644 --- a/src/GoogleMapField.php +++ b/src/GoogleMapField.php @@ -102,9 +102,9 @@ public function hasData() public function setValue($value, $data = null) { - if ($data) { - $this->setDataRecord($data); - } else if (!$this->children->count()) { + $this->setDataRecord($value); + + if (!$this->children->count()) { $this->setupChildren(); }