Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.
This repository was archived by the owner on May 17, 2019. It is now read-only.

Make withFontLoading HOC compatible with Styletron's withStyle #108

@dhdemerson

Description

@dhdemerson

Type of issue

Feature Request

Description

Fusion.js uses Styletron for managing component styles. Composing styles in Styletron is accomplished using withStyle, withStyleDeep, and withTransform functions. Ideally this plugin would be compatible with those functions to allow composition of styles where fonts are being loaded.

Current behavior

If withStyle is called on a styled component wrapped in a withFontLoading HOC a TypeError is produced.

Expected behavior

withStyle should be able to create styled components wrapped by a withFontLoading HOC with font loading from the base component.

OR

Styled component composition with font loading should be addressed in the documentation describing workarounds, patterns, or general guidance.

Steps to reproduce

N/A

Your environment

  • fusion-plugin-font-loader-react version: 1.0.3

  • Node.js version (node --version): Any

  • npm version (npm --version): Any

  • Operating System: Any

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions