Skip to content

Temporarily disable expect_error() tests that cause workers to leak #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavisVaughan merged 1 commit into from
Jan 30, 2026
Merged

Temporarily disable expect_error() tests that cause workers to leak #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/testthat/helper-state.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Detects leaked workers in tests, which show up as:
#
# ```
# Warning message:
# In .Internal(gc(verbose, reset, full)) :
# closing unused connection 4 (<-localhost:11913)
# ```
#
# If a leaked connection is detected, a warning is thrown by testthat for
# the problematic test.
#
# We keep this on constantly to ensure we aren't leaking connections. It has
# also been helpful for detecting future issues around leaked workers (#307).
set_state_inspector(function() {
getAllConnections()
})
9 changes: 6 additions & 3 deletions tests/testthat/test-furrr-options.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,12 @@ test_that("can selectively export packages on multisession", {

opts <- furrr_options(packages = "dplyr")

expect_error(
future_map(1:2, ~ tibble(x = .x))
)
# TODO: Reenable this test after future issue is fixed
# https://github.com/futureverse/future/issues/820
# https://github.com/futureverse/furrr/issues/307
# expect_error(
# future_map(1:2, ~ tibble(x = .x))
# )

expect_identical(
future_map(1:2, ~ tibble(x = .x), .options = opts),
Expand Down
6 changes: 5 additions & 1 deletion tests/testthat/test-future-map.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,11 @@ furrr_test_that("`.f` globals are only looked up in the function env of `.f` (#1
future_map(1:2, f)
}

expect_error(wrapper(fn), "'y' not found")
# TODO: Reenable this test after future issue is fixed
# https://github.com/futureverse/future/issues/820
# https://github.com/futureverse/furrr/issues/307
# expect_error(wrapper(fn), "'y' not found")

expect_identical(wrapper(fn2), list(-1, -1))
})

Expand Down
25 changes: 14 additions & 11 deletions tests/testthat/test-future-map2.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,17 +186,20 @@ furrr_test_that("size one recycling works", {
)
})

furrr_test_that("generally can't recycle to size zero", {
expect_error(
future_map2(1:2, integer(), ~ c(.x, .y)),
"Can't recycle"
)

expect_error(
future_map2(integer(), 1:2, ~ c(.x, .y)),
"Can't recycle"
)
})
# TODO: Reenable this test after future issue is fixed
# https://github.com/futureverse/future/issues/820
# https://github.com/futureverse/furrr/issues/307
# furrr_test_that("generally can't recycle to size zero", {
# expect_error(
# future_map2(1:2, integer(), ~ c(.x, .y)),
# "Can't recycle"
# )
#
# expect_error(
# future_map2(integer(), 1:2, ~ c(.x, .y)),
# "Can't recycle"
# )
# })

# ------------------------------------------------------------------------------
# Miscellaneous
Expand Down
31 changes: 19 additions & 12 deletions tests/testthat/test-future-pmap.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,17 +189,20 @@ furrr_test_that("size one recycling works", {
)
})

furrr_test_that("generally can't recycle to size zero", {
expect_error(
future_pmap(list(1:2, integer()), ~ c(.x, .y)),
"Can't recycle"
)

expect_error(
future_pmap(list(integer(), 1:2), ~ c(.x, .y)),
"Can't recycle"
)
})
# TODO: Reenable this test after future issue is fixed
# https://github.com/futureverse/future/issues/820
# https://github.com/futureverse/furrr/issues/307
# furrr_test_that("generally can't recycle to size zero", {
# expect_error(
# future_pmap(list(1:2, integer()), ~ c(.x, .y)),
# "Can't recycle"
# )
#
# expect_error(
# future_pmap(list(integer(), 1:2), ~ c(.x, .y)),
# "Can't recycle"
# )
# })

# ------------------------------------------------------------------------------
# Miscellaneous
Expand Down Expand Up @@ -237,7 +240,11 @@ furrr_test_that("unused components can be absorbed", {
x
}

expect_error(future_pmap_dbl(x, fn1))
# TODO: Reenable this test after future issue is fixed
# https://github.com/futureverse/future/issues/820
# https://github.com/futureverse/furrr/issues/307
# expect_error(future_pmap_dbl(x, fn1))

expect_identical(future_pmap_dbl(x, fn2), c(1, 2))
})

Expand Down