go back to only walking visible trees in EnsureMinSize

Author: dweymouth

cmd/fyne_demo/main.go

@@ -253,10 +253,10 @@ func makeNav(setTutorial func(tutorial tutorials.Tutorial), loadPrevious bool) f
 
 	themes := container.NewGridWithColumns(2,
 		widget.NewButton("Dark", func() {
-			//a.Settings().SetTheme(&forcedVariant{Theme: theme.DefaultTheme(), variant: theme.VariantDark})
+			a.Settings().SetTheme(&forcedVariant{Theme: theme.DefaultTheme(), variant: theme.VariantDark})
 		}),
 		widget.NewButton("Light", func() {
-			//a.Settings().SetTheme(&forcedVariant{Theme: theme.DefaultTheme(), variant: theme.VariantLight})
+			a.Settings().SetTheme(&forcedVariant{Theme: theme.DefaultTheme(), variant: theme.VariantLight})
 		}),
 	)
 

internal/driver/common/canvas.go

@@ -124,7 +124,7 @@ func (c *Canvas) EnsureMinSize() bool {
 			}
 		}
 	}
-	c.WalkCompleteTrees(nil, ensureMinSize)
+	c.WalkTrees(nil, ensureMinSize)
 
 	shouldResize := windowNeedsMinSizeUpdate && (csize.Width < min.Width || csize.Height < min.Height)
 	if shouldResize {

internal/driver/glfw/canvas.go

@@ -258,7 +258,7 @@ func (c *glCanvas) markAlive(visibleOnly bool) {
 		case *canvas.Text:
 			_, _ = cache.GetTextTexture(glcommon.FontCacheEntryForText(obj, c))
 		case fyne.Widget:
-			_ = cache.Renderer(obj)
+			_, _ = cache.CachedRenderer(obj)
 		}
 	}
 

internal/driver/glfw/loop.go

@@ -78,6 +78,11 @@ func (d *gLDriver) drawSingleFrame() {
 				d.cleanInactiveWindowTextures(w, !shouldCleanCanvases /*walkVisibleOnly*/)
 			}
 			continue
+		} else if shouldCleanCanvases {
+			// EnsureMinSize and paint only walk visible trees.
+			// Walk entire trees of window and mark alive,
+			// so that we do not clean CanvasForObject entries of hidden objects.
+			w.canvas.markAlive(false /*visibleOnly*/)
 		}
 
 		refreshed = refreshed || d.repaintWindow(w, shouldClean)