golang-lint update

Author: jinuthankachan

.github/workflows/golangci-lint.yml

@@ -4,35 +4,41 @@ on:
     tags:
       - v*
     branches:
+      - master
       - main
   pull_request:
 permissions:
   contents: read
   # Optional: allow read access to pull request. Use with `only-new-issues` option.
-  # pull-requests: read
+  pull-requests: read
 jobs:
   golangci:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/setup-go@v4
+        with:
+          go-version: '1.17'
+          cache: false
+      - uses: actions/checkout@v3
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: latest
+          version: v1.29
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir
 
           # Optional: golangci-lint command line arguments.
-          # args: -E gosec -E megacheck -E govet -E goconst -E lll -E gocritic -E gocyclo -E godox -E dupl -E depguard
+          # args: --issues-exit-code=0
 
           # Optional: show only new issues if it's a pull request. The default value is `false`.
           # only-new-issues: true
 
-          # Optional: if set to true then the action will use pre-installed Go.
-          # skip-go-installation: true
+          # Optional: if set to true then the all caching functionality will be complete disabled,
+          #           takes precedence over all other caching options.
+          # skip-cache: true
 
           # Optional: if set to true then the action don't cache or restore ~/go/pkg.
           # skip-pkg-cache: true

.gitignore

@@ -11,5 +11,7 @@
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
 
-# Dependency directories (remove the comment below to include it)
+# Directories (remove the comment below to include it)
 # vendor/
+out/
+bin/

Makefile

@@ -0,0 +1,22 @@
+
+GOTEST=go test
+BINARY_NAME=goframe
+
+.PHONY: test build run clean go-lint
+
+build: ## Build project and put the output binary in bin/
+	mkdir -p bin/
+	GO111MODULE=on go build -o bin/$(BINARY_NAME) .
+
+clean: ## Remove build related file
+	rm -fr ./bin
+
+run: build
+	./bin/$(BINARY_NAME)
+
+## Test:
+test: 
+	$(GOTEST) -cover -v -race ./... 
+
+go-lint:
+	docker run -t --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.52.2 golangci-lint run -v

app.go

@@ -46,12 +46,12 @@ func (a *app) SetInCtx(key string, value interface{}) {
 // In production configs can be stored as env vars.
 //
 // Defaults:
-// * The default config reader expects the config files
-// 	 to be kept inside configs/ dir in app root dir.
-// * The name of the app would be the default expected config file name.
-// * While using env vars, `_` would be the default separator.
-// * The env vars would have the app name as a default prefix.
-// * eg. for app name "simple" -> simple_server_host
+//   - The default config reader expects the config files
+//     to be kept inside configs/ dir in app root dir.
+//   - The name of the app would be the default expected config file name.
+//   - While using env vars, `_` would be the default separator.
+//   - The env vars would have the app name as a default prefix.
+//   - eg. for app name "simple" -> simple_server_host
 func (a *app) Config() Config { return a.config }
 
 // NewApp returns an instance of app.