Skip to content

fix (posts block): fix image width in horizontal block styles #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix (posts block): fix image width in horizontal block styles #3649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src/block/posts/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,26 +281,13 @@ Image.addStyles( blockStyles, {
const blockStyle = getBlockStyle( variations, className )
return ! [ 'list', 'horizontal', 'horizontal-2', 'portfolio', 'portfolio-2', 'vertical-card-2' ].includes( blockStyle?.name )
},
saveEnableWidthCallback: getAttribute => {
const className = getAttribute( 'className' )
const imageHasLink = getAttribute( 'imageHasLink' )
const blockStyle = getBlockStyle( variations, className )

if ( [ 'horizontal', 'horizontal-2' ].includes( blockStyle?.name ) ) {
if ( imageHasLink ) {
return false
}
return true
}
return true
},
selectorCallback: ( getAttribute, _attributes, _clientId, props ) => {
const className = getAttribute( 'className' )
const blockStyle = getBlockStyle( variations, className )
const imageHasLink = getAttribute( 'imageHasLink' )

const selector = props.selector
if ( [ 'list' ].includes( blockStyle?.name ) && imageHasLink ) {
if ( [ 'list', 'horizontal', 'horizontal-2' ].includes( blockStyle?.name ) && imageHasLink ) {
return Array.isArray( selector )
? [ ...selector, `${ itemSelector } .stk-block-posts__image-link` ]
: [ selector, `${ itemSelector } .stk-block-posts__image-link` ]
Expand All @@ -312,7 +299,7 @@ Image.addStyles( blockStyles, {
const blockStyle = getBlockStyle( variations, className )
const imageHasLink = getAttribute( 'imageHasLink' )

if ( [ 'list' ].includes( blockStyle?.name ) && imageHasLink ) {
if ( [ 'list', 'horizontal', 'horizontal-2' ].includes( blockStyle?.name ) && imageHasLink ) {
return 'flexBasis'
}
return 'width'
Expand Down
Loading