From 98445f97136aa4c0e48484d3c402d2e17e506f57 Mon Sep 17 00:00:00 2001 From: Bartek Czech Date: Tue, 12 Aug 2025 08:04:42 +0200 Subject: [PATCH 1/3] fix: usage of ifelse --- R/build_tools.R | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/R/build_tools.R b/R/build_tools.R index febb8ad..bfc0e44 100644 --- a/R/build_tools.R +++ b/R/build_tools.R @@ -237,11 +237,14 @@ install_github <- function(name, if (is.null(pkg$ref)) { pkg$ref <- "HEAD" } + + host_url <- if (!is.null(pkg$host)) pkg$host else "api.github.com" + remotes::install_github( repo = pkg$url, ref = pkg$ref, subdir = pkg$subdir, - host = ifelse(!is.null(pkg$host), pkg$host, "api.github.com"), + host = host_url, upgrade = "never" ) verify_version(name, pkg$ver) From 8f56731b3439b163b6c0f74a68bb4fa24ca988fa Mon Sep 17 00:00:00 2001 From: Bartek Czech Date: Tue, 12 Aug 2025 08:04:47 +0200 Subject: [PATCH 2/3] chore: bump version and update NEWS.md --- DESCRIPTION | 4 ++-- NEWS.md | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 52f618d..081bb94 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: gDRstyle Type: Package Title: A package with style requirements for the gDR suite -Version: 1.7.3 -Date: 2025-08-03 +Version: 1.7.4 +Date: 2025-08-12 Authors@R: c( person("Allison", "Vuong", role=c("aut")), person("Dariusz", "Scigocki", role=c("aut")), diff --git a/NEWS.md b/NEWS.md index e8f1b47..2515aae 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,6 @@ +## gDRstyle 1.7.4 - 2025-08-12 +* fix usage of `ifelse` + ## gDRstyle 1.7.3 - 2025-08-04 * added support for skipping vignette building in `run_tests.sh` From ae1265635d5af2a4cd5d1b62f6be98e243913037 Mon Sep 17 00:00:00 2001 From: Bartek <32614650+bczech@users.noreply.github.com> Date: Thu, 21 Aug 2025 09:26:07 +0200 Subject: [PATCH 3/3] refactor: Update build_tools.R --- R/build_tools.R | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/R/build_tools.R b/R/build_tools.R index bfc0e44..b5391fc 100644 --- a/R/build_tools.R +++ b/R/build_tools.R @@ -238,7 +238,11 @@ install_github <- function(name, pkg$ref <- "HEAD" } - host_url <- if (!is.null(pkg$host)) pkg$host else "api.github.com" + host_url <- if (!is.null(pkg$host)) { + pkg$host + } else { + "api.github.com" + } remotes::install_github( repo = pkg$url,