add tests #13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Owner
There was a problem hiding this comment. Call the test functions with the it expression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| const Line = require('../../../modules/ecs6-class/line'); | ||
| const Point = require('../../../modules/ecs6-class/point'); | ||
|
|
||
| const getPointByYMock = jest | ||
| .spyOn(Line.prototype, 'getPointByY') | ||
|
|
||
| const getPointByXMock = jest | ||
| .spyOn(Line.prototype, 'getPointByX') | ||
|
|
||
|
Owner
There was a problem hiding this comment. where do you restore the mocks?
Owner
There was a problem hiding this comment. use this mocks inside the test where they are needed |
||
|
|
||
|
|
||
| describe('Check calculateSlope function', () => { | ||
| it(' Should return the slope of the line', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2 }); | ||
| line1.calculateSlope(); | ||
| expect(line1.slope).toBe(-0.5) | ||
| }) | ||
| it(' Should return 0 if the points are in the same position on the x-axis', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 7 }); | ||
| let line1 = new Line({ point1, point2 }); | ||
| line1.calculateSlope(); | ||
| expect(line1.slope).toBe(0) | ||
| }) | ||
| describe('ERRORS', () => { | ||
| it('should throw error when the type is not valid', () => { | ||
| let point1 = new Point({ x: 3, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2 }); | ||
| expect(() => line1.calculateSlope()).toThrow("it isn't a real geometry line") | ||
|
|
||
|
|
||
| }) | ||
| }) | ||
|
|
||
| }) | ||
|
|
||
| describe('Check calculateNOfLineFunction function', () => { | ||
| it('Should return n of the line', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2, slope: -0.5 }); | ||
| line1.calculateNOfLineFunction(); | ||
| expect(line1.n).toBe(9.5) | ||
| }) | ||
| it('Should return n of the line and computer the slpoe if it is not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2 }); | ||
| line1.calculateNOfLineFunction(); | ||
| expect(line1.slope).toBe(-0.5) | ||
| expect(line1.n).toBe(9.5) | ||
| }) | ||
| }) | ||
|
|
||
| describe('Check getPointOnXAsis function', () => { | ||
|
Owner
There was a problem hiding this comment. You are testing only if the mock was called, but where are the tests about the values of the function?? |
||
| it('It should be returned if in the call to the function the function getPointByY was called', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| const line1 = new Line({point1,point2,n:7,slope:6}); | ||
| line1.getPointOnXAsis(); | ||
| expect(getPointByYMock).toHaveBeenCalled(); | ||
| }); | ||
| }) | ||
|
|
||
| describe('Check getPointOnYAsis function', () => { | ||
| it('It should be returned if in the call to the function the function getPointByX was called', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| const line1 = new Line({point1,point2,n:7,slope:6}); | ||
| line1.getPointOnYAsis(); | ||
| expect(getPointByXMock).toHaveBeenCalled(); | ||
| }); | ||
| }) | ||
|
|
||
|
|
||
| describe('Check getPointByX function', () => { | ||
| it(' Should return point', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2, slope: 2, n: 7 }); | ||
| expect(line1.getPointByX(6)).toEqual({ x: 6, y: 19 }) | ||
|
|
||
| }) | ||
| it('Should return point and computer the slpoe if it is not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2, n: 7 }); | ||
| expect(line1.getPointByX(6)).toEqual({ x: 6, y: 4 }) | ||
| expect(line1.slope).toBe(-0.5) | ||
| }) | ||
| it('Should return point and computer the n if it is not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2, slope:-0.5 }); | ||
| expect(line1.getPointByX(6)).toEqual({ x: 6, y: 6.5 }) | ||
| expect(line1.n).toBe(9.5) | ||
| }) | ||
| it('Should return a point and calculate n and the slope if they are not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2}); | ||
| expect(line1.getPointByX(6)).toEqual({ x: 6, y: 6.5 }) | ||
| expect(line1.slope).toBe(-0.5) | ||
| expect(line1.n).toBe(9.5) | ||
| }) | ||
| describe('ERRORS', () => { | ||
| it('should throw error when the type is not valid', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2 }); | ||
| expect(() => line1.getPointByX({ x: 1 })).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByX('o')).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByX(false)).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByX([1, 2])).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByX()).toThrow("The value is of an invalid type") | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('Check getPointByY function', () => { | ||
| it('Should return point ', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1,point2,slope: 2, n: 7 }); | ||
| expect(line1.getPointByY(6)).toEqual({ x: -0.5, y: 6 }) | ||
| }) | ||
| it('Should return point and computer the slpoe if it is not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2, n: 9.5 }); | ||
| expect(line1.getPointByY(6)).toEqual({ x: 7, y: 6 }) | ||
| expect(line1.slope).toBe(-0.5) | ||
| }) | ||
| it('Should return point and computer the n if it is not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2, slope:-0.5 }); | ||
| expect(line1.getPointByY(6)).toEqual({ x: 7, y: 6 }) | ||
| expect(line1.n).toBe(9.5) | ||
| }) | ||
| it('Should return a point and calculate n and the slope if they are not sent', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2}); | ||
| expect(line1.getPointByY(6)).toEqual({ x: 7, y: 6 }) | ||
| expect(line1.slope).toBe(-0.5) | ||
| expect(line1.n).toBe(9.5) | ||
| }) | ||
| describe('ERRORS', () => { | ||
| it('should throw error when the type is not valid', () => { | ||
| let point1 = new Point({ x: 5, y: 7 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1 = new Line({ point1, point2 }); | ||
| expect(() => line1.getPointByY({ x: 2 })).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByY('o')).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByY(false)).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByY([1, 2])).toThrow('The value is of an invalid type') | ||
| expect(() => line1.getPointByY()).toThrow("The value is of an invalid type") | ||
| }) | ||
| it('should throw error when The slope is equal to 0',()=>{ | ||
| let point1 = new Point({ x: 5, y: 8 }); | ||
| let point2 = new Point({ x: 3, y: 8 }); | ||
| let line1= new Line({ point1, point2 ,slope:0}); | ||
| expect(() => line1.getPointByY(21)).toThrow("The slope cannot be 0") | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('ERRORS', () => { | ||
| it('should throw error when the values of the line is not valid', () => { | ||
| let point1 = new Point({ x: 2, y: 3 }) | ||
| let point2 = new Point({ x: 4, y: 5 }) | ||
| let line1; | ||
| expect(() => line1 = new Line({ point1: 9, point2, n: 4, slope: 6 })).toThrow('The point1 should be a Point type') | ||
| expect(() => line1 = new Line({ point1, point2: [1, 2], n: 4, slope: 6 })).toThrow('The point2 should be a Point type') | ||
| expect(() => line1 = new Line({ point1, point2, n: 'c', slope: 6 })).toThrow('The n should have a number') | ||
| expect(() => line1 = new Line({ point1, point2, n: 4, slope: false })).toThrow('The slope should have a number') | ||
|
|
||
| }) | ||
| }) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.