Skip to content

add more test #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmanela wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add more test #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
049ec26
add tests on point line and geomatry-calculate
rmanela Jul 25, 2024
84fac57
add tests on point line and geomatry-calculate
rmanela Jul 25, 2024
0bb3872
add tests on point line and geomatry-calculate
rmanela Jul 25, 2024
633ae31
add more tests
rmanela Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions modules/ecs6-class/line.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ const Point = require("./point");

class Line {
constructor({ point1 = new Point(), point2 = new Point(), n = undefined, slope = undefined }) {


this.point1 = point1;
this.point2 = point2;
this.slope = slope;
Expand All @@ -13,10 +15,18 @@ class Line {
}

calculateNOfLineFunction = () => {

if (this.slope === undefined) {
throw new Error("the slope must be defined")
}
if (typeof (this.slope) !== "number") {
throw new Error("the slope must be number")
}
this.n = this.point1.y - this.slope * this.point1.x
}

getPointOnXAsis() {

return this.getPointByY(0)
}

Expand All @@ -26,13 +36,38 @@ class Line {


getPointByX(x) {
if (x === undefined) {
throw new Error("the function getPointByX must get x")
}
if (typeof (x) !== "number") {
throw new Error("the function getPointByX must get x of type number")
}
if (this.slope === undefined) {
throw new Error("slope must be defined")
}
if (typeof (this.slope) !== "number") {
throw new Error("slope must of type number")
}
if (this.n === undefined) {
throw new Error("n must be defined")
}
if (typeof (this.n) !== "number") {
throw new Error("n must be number")
}
let y = this.slope * x + this.n
return new Point({ x, y })
return new Point({ x: x, y: y })
}

getPointByY(y) {
if (y === undefined) {
throw new Error("the function getPointByY must get y")
}
if (typeof (y) !== "number") {
throw new Error("the function getPointByY must get y of type number")
}

let x = (y - this.n) / this.slope;
return new Point({ x, y })
return new Point({ x: x, y: y })
}
}

Expand Down
21 changes: 20 additions & 1 deletion modules/ecs6-class/point.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,33 @@
class Point {
constructor({x=0, y=0}={}) {
constructor({x=0,y=0}={}){
if (typeof (x) !== "number" || typeof (y) !== "number") {
throw new Error("the argument must be type number")
}
this.x = x;
this.y = y;
}
moveVertical(value) {
if (!value) {
throw new Error("the function must get argument")
}


if (typeof (value) !== "number") {
throw new Error("the argument must be type number")
}

this.y += value;
}
moveHorizontal(value) {
if (!value) {
throw new Error("the function must get argument")
}
if (typeof (value) !== "number") {
throw new Error("the argument must be type number")
}
this.x += value;
}
}


module.exports = Point
23 changes: 20 additions & 3 deletions modules/geometry-calculation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,27 @@
const Line = require('./ecs6-class/line')
const Line = require('./ecs6-class/line');
const Point = require('./ecs6-class/point');

const calculateDistance = (point1, point2) => {
if (point1 == undefined || point2 == undefined) {
throw new Error("the function calculateDistance must get 2 points")
}
if (!(point1 instanceof Point) || !(point2 instanceof Point)) {
throw new Error("the function calculateDistance must get 2 points of type Point")
}
let distanceX = (point2.x - point1.x) ** 2;
let distanceY = (point2.y - point2.y) ** 2;
let distanceY = (point2.y - point1.y) ** 2;
const distance = Math.sqrt(distanceX + distanceY);
return distance;
}

const calculateJunctionPoint = (line1, line2) => {
if (line1 == undefined || line2 == undefined)
throw new Error("the function calculateJunctionPoint must get 2 lines")

if (!(line1 instanceof Line) || !(line2 instanceof Line)) {
throw new Error("the function calculateJunctionPoint must get 2 lines of type Line")
}

if (line1.slope === line2.slope) {
if (line1.n === line2.n) {
return true
Expand All @@ -24,17 +38,20 @@ const calculateJunctionPoint = (line1, line2) => {
}

const isPointOnLine = (line, point) => {
const proxyLine = new Line({ point1: line.point1, point2: point })

const proxyLine = new Line({ point1: line.point1, point2: point, n: undefined, slope: undefined })
proxyLine.calculateSlope()
if (line.slope === proxyLine.slope) {
proxyLine.calculateNOfLineFunction()

if (line.n === proxyLine.n) {
return true
}
}
return false
}


module.exports = {
calculateDistance,
calculateJunctionPoint,
Expand Down
18 changes: 11 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
"description": "practice unit tests in javascript",
"main": "index.js",
"scripts": {
"test": "jest"
"test": "jest",
"test:coverage":"jest --coverage"
},
"dependencies": {

},
"devDependencies": {
"jest": "^29.7.0"
},
"repository": {
Expand Down
Empty file added test/line.test
View file
Open in desktop
Empty file.
147 changes: 147 additions & 0 deletions test/modules/ecs6-class/line.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
const { default: expect } = require("expect")
const Line = require("../../../modules/ecs6-class/line")
const Point = require("../../../modules/ecs6-class/point")

describe("LINE_FUNCTION", function () {
describe("BUILD_LINE", function () {
it("should show the points of line after build the line", function () {
let p1 = new Point({ x: 1, y: 2 })
let p2 = new Point({ x: 3, y: 4 })
let point1 = new Point({ x: 5, y: 5 })
let point2 = new Point({ x: 6, y: 6 })
let l1 = new Line({ point1: p1, point2: p2, n: 2, slope: -3 })
let l2 = new Line({ point1: point1, point2: point2, })
let l3 = new Line({ point1: undefined, point2: undefined })
expect(l3.n).toBe(undefined)
expect(l1.point1.x).toEqual(1)
expect(l1.point1.y).toEqual(2)
expect(l1.point2.x).toEqual(3)
expect(l1.point2.y).toEqual(4)
expect(l2.point1.x).toEqual(5)
expect(l2.point1.y).toEqual(5)
expect(l2.point2.x).toEqual(6)
expect(l2.point2.y).toEqual(6)
})

it("should show the n and slope of line after build the line", function () {
let p1 = new Point({ x: 1, y: 2 })
let p2 = new Point({ x: 3, y: 4 })
let point1 = new Point({ x: 5, y: 5 })
let point2 = new Point({ x: 6, y: 6 })
let l1 = new Line({ point1: p1, point2: p2, n: 2, slope: -3 })
let l2 = new Line({ point1: point1, point2: point2, })
let l3 = new Line({ point1: undefined, point2: undefined })
expect(l1.n).toEqual(2)
expect(l1.slope).toEqual(-3)
expect(l2.n).toBe(undefined)
expect(l2.slope).toBe(undefined)
})
})
describe("CALCULATE_SLOPE", function () {
it("should calculate the slope between 2 points", function () {
let p1 = new Point({ x: 1, y: 2 })
let p2 = new Point({ x: 3, y: 4 })
let point1 = new Point({ x: 10, y: 100 })
let point2 = new Point({ x: 5, y: 50 })
let l1 = new Line({ point1: p1, point2: p2, n: 2, slope: -3 })
let l2 = new Line({ point1: point1, point2: point2 })
expect(l1.slope).toEqual(-3)
l1.calculateSlope()
l2.calculateSlope()
expect(l1.slope).toEqual(1)
expect(l2.slope).toEqual(10)
})
})

describe("CALCULATE_N_OF_LINE_FUNCTION", function () {
it("should calculate the n of line function according to point1 and point2 and slope", function () {
let p1 = new Point({ x: 1, y: 2 })
let p2 = new Point({ x: 3, y: 4 })
let point1 = new Point({ x: 5, y: 5 })
let point2 = new Point({ x: 6, y: 6 })
let l1 = new Line({ point1: p1, point2: p2, n: 2, slope: -3 })
let l2 = new Line({ point1: point1, point2: point2, })
l1.calculateSlope()
l2.calculateSlope()
l1.calculateNOfLineFunction()
l2.calculateNOfLineFunction()
expect(l1.n).toEqual(1)
expect(l2.n).toEqual(0)

})
})

describe("GET_POINT_ON_Y_ASIS", function () {
it("should retutn a new point on y", function () {
let line1 = new Line({ point1: new Point({ x: 1, y: 6 }), point2: new Point({ x: 2, y: 3 }), n: 9, slope: -3 })
expect(line1.getPointOnYAsis()).toStrictEqual(new Point({ x: 0, y: 9 }))
})
})

describe("GET_POINT_ON_X_ASIS", function () {
it("should retutn a new point on x", function () {
let line1 = new Line({ point1: new Point({ x: 1, y: 6 }), point2: new Point({ x: 2, y: 3 }), n: 9, slope: -3 })
expect(line1.getPointOnXAsis()).toStrictEqual(new Point({ x: 3, y: 0 }))
})
})

describe("GET_POINT_BY_X", function () {
it("should calculate y of point on line according to x", function () {
let l2 = new Line({ point1: new Point({ x: 5, y: 6 }), point2: new Point({ x: 7, y: 8 }), n: 1, slope: 1 })
expect(l2.getPointByX(1)).toEqual({ x: 1, y: 2 })

})
})


describe("GET_POINT_BY_Y", function () {
it("should calculate x of point on line according to y", function () {
let l2 = new Line({ point1: new Point({ x: 5, y: 6 }), point2: new Point({ x: 7, y: 8 }), n: 1, slope: 1 })

expect(l2.getPointByY(1)).toEqual({ x: 0, y: 1 })
})
})

describe("ERROR", function () {
let line = new Line({ point1: new Point({ x: 3, y: 7 }), point2: new Point({ x: 9, y: 7 }), n: 9 })
let line2 = new Line({ point1: new Point({ x: 3, y: 7 }), point2: new Point({ x: 9, y: 7 }), n: 9, slope: "jskjk" })
let line3 = new Line({ point1: new Point({ x: 3, y: 7 }), point2: new Point({ x: 9, y: 7 }), n: 9, slope: 6 })
let line4 = new Line({ point1: "huhj", point2: "jij", n: "9", slope: "ijdi" })
let line5 = new Line({ point1: new Point({ x: 3, y: 7 }), point2: new Point({ x: 9, y: 7 }), n: 9, slope: "jhj" })
let line6 = new Line({ point1: new Point({ x: 3, y: 7 }), point2: new Point({ x: 9, y: 7 }), slope: 99 })
let line7 = new Line({ point1: new Point({ x: 3, y: 7 }), point2: new Point({ x: 9, y: 7 }), n: "ghg", slope: 99 })

it("the slope of line must be defined", function () {
expect(() => { line.calculateNOfLineFunction() }).toThrow("the slope must be defined")
})

it("the slope of line must be number", function () {
expect(() => { line2.calculateNOfLineFunction() }).toThrow("the slope must be number")
})
it("the function getPointByX must get x", function () {
expect(() => { line3.getPointByX() }).toThrow("the function getPointByX must get x")
})
it("the function getPointByX must get x of type number", function () {
expect(() => { line3.getPointByX("iui") }).toThrow("the function getPointByX must get x of type number")
})
it("the function getPointByX must get n of type number", function () {
expect(() => { line6.getPointByX(1) }).toThrow("n must be defined")
})
it("the function getPointByX must get n of type number", function () {
expect(() => { line7.getPointByX(1) }).toThrow("n must be number")
})
it(" in function getPointByX slope must be defined", function () {
expect(() => { line.getPointByX(4) }).toThrow("slope must be defined")
})
it(" in function getPointByX slope must of type number", function () {
expect(() => { line5.getPointByX(4) }).toThrow("slope must of type number")
})
it("the function getPointByY must get y", function () {
expect(() => { line3.getPointByY() }).toThrow("the function getPointByY must get y")
})
it("the function getPointByY must get y of type number", function () {
expect(() => { line3.getPointByY("iui") }).toThrow("the function getPointByY must get y of type number")
})

})
})
Loading