Variable function parameters needs a better declaration...

[geneb]

Lance brought to my attention a function declaration in op_ccall.c that goes like this:

u_int64 (*Fn0)();

Now ignoring the absolutely horrifying choice of variable name, he pointed out that the function pointer can be leveraged to call other functions and pass anywhere from none, to up to 50 parameters.

When we set the C standard to use at C17, this is no problem. However, C23 doesn't like that declaration AT ALL. The proposed fix is to make the declaration Fn0(...). GCC likes it and it seems to work, so....

[geneb]

Done.

[hunger1]

Using cc (GCC) 11.5.0, which is standard with RHEL 9, that line results in:

ScarletDME/gplsrc/op_ccall.c: In function 'ccall_c':
ScarletDME/gplsrc/op_ccall.c:94:18: error: ISO C requires a named argument before '...'
94 | u_int64 (Fn0)(...); / git issue #81 */

Perhaps this might be better:

#if defined(GNUC) && (GNUC > 11)
u_int64 (Fn0)(...); / git issue #81 */
#else
u_int64 (*Fn0)();
#endif

I don't know which version of gcc no longer required the named argument, so 11 may not be the right number.

In addition, using -std=c2x in Makefile will do very different things based on the version of gcc in use. I recommend using -std=c17 or -std=c23 instead.

[geneb]

Thanks for pointing that out. I was experimenting with a few things and had intended to use -std=c23 and simply forgot to change it back.

I'll also address the issue in ccall.c.

[geneb]

I implemented your change for Fn0 - pull it and see how it goes.