From 2feee7522eed3bfa4288d185269e06f7562a0b70 Mon Sep 17 00:00:00 2001
From: gaboesquivel <contact@gaboesquivel.com>
Date: Mon, 2 Oct 2017 12:04:43 -0600
Subject: [PATCH] fix stories.all, return all stories rel #20

---
 lib/resources/story.js | 65 ++++++++++++++++++++++++++----------------
 package.json           |  5 ++--
 2 files changed, 44 insertions(+), 26 deletions(-)

diff --git a/lib/resources/story.js b/lib/resources/story.js
index 2c25c84..5e34ad1 100644
--- a/lib/resources/story.js
+++ b/lib/resources/story.js
@@ -2,8 +2,8 @@
     Source, Story resource structure:
     https://www.pivotaltracker.com/help/api/rest/v5#story_resource
 */
-
-var activity = require('./activity'),
+var merge = require('lodash.merge'),
+    activity = require('./activity'),
     comment = require('./comment'),
     label = require('./label'),
     task = require('./task'),
@@ -445,24 +445,56 @@ Service.prototype.task = function(taskId) {
 };
 
 Service.prototype.all = function(options, cb) { // cb(err, stories[])
+    var defaultOptions = {  
+        limit: 500, 
+        offset: 0 
+    };
     if (typeof options === 'function' && typeof cb === 'undefined') {
         cb = options;
-        options = null; // options is an optional param
+        options = {}; // options is an optional param
     }
 
-    if (!this.projectId) {
-        cb(new Error('Invalid project ID'), null);
-    }
-    else {
-        ptutil.api.get(
+    options = merge(defaultOptions, options);
+    var allStories = []
+    
+    function getStories (allStories) {
+        var _this = this;
+
+        return ptutil.api.get(
             this.config.trackerToken,
             this.pathSegments(),
             options, // query
             this.config, // options
             function(error, res) {
-                _callbackWithStories(error, res, cb);
+                if(error) {
+                    return cb(error);
+                 }
+
+                if (!error && res && Array.isArray(res.data) && res.data.length) {
+                    res.data.forEach(function(ele) {
+                        allStories.push(new Story(ele));
+                    });
+                }
+
+                if(res.data.length <= 0) {
+                   return cb(null, allStories);
+                }
+
+                // recursion in 500 batches, currently there's no way to tell how many piv stories in total
+                options.limit+=500;
+                options.offset+=500;
+                getStories.call(_this, allStories);
             });
+    };
+
+   
+    if (!this.projectId) {
+        cb(new Error('Invalid project ID'), null);
+    } else {
+        return getStories.call(this, allStories);
     }
+
+    
 };
 
 Service.prototype.get = function(cb) { // cb(err, story)
@@ -560,21 +592,6 @@ function _callbackWithStory(error, res, cb) {
     cb(error, result);
 }
 
-function _callbackWithStories(error, res, cb) {
-
-    var arr = [];
-
-    if (!error && res && Array.isArray(res.data) && res.data.length) {
-
-        res.data.forEach(function(ele) {
-
-            arr.push(new Story(ele));
-        });
-    }
-
-    cb(error, arr);
-}
-
 function _serviceToString() {
     var str = 'token: '+this.config.trackerToken+'\n';
         str += 'projectId'+this.projectId+'\n';
diff --git a/package.json b/package.json
index 625f893..992e4a9 100644
--- a/package.json
+++ b/package.json
@@ -38,8 +38,9 @@
     "test": "nodeunit ./tests/unit/run.js"
   },
   "dependencies": {
-    "request": "2.33.x",
-    "form-data": "~0.1.2"
+    "form-data": "~0.1.2",
+    "lodash.merge": "^4.6.0",
+    "request": "2.33.x"
   },
   "devDependencies": {
     "nodeunit": "latest",