Setting Header no-store was throwing an exception (#859)

* Setting Header no-store was throwing an exception when assigned with the expression HttpContext.Current.Response.CacheControl = parsedValue.ToString();

* Fix build error.

Author: claudiamurialdo

dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs

@@ -2425,62 +2425,59 @@ public byte SetHeader(string name, string value)
 				_httpHeaders = new NameValueCollection();
 			}
 			_httpHeaders[name] = value;
-			SetCustomHttpHeader(name, value);
-			return 0;
+			return SetCustomHttpHeader(name, value);
 		}
 
-		private void SetCustomHttpHeader(string name, string value)
+		private byte SetCustomHttpHeader(string name, string value)
 		{
 			try
 			{
 #if !NETCORE
 
 				if (name.Equals(HeaderNames.CacheControl, StringComparison.OrdinalIgnoreCase))
 				{
-					if (System.Net.Http.Headers.CacheControlHeaderValue.TryParse(value, out System.Net.Http.Headers.CacheControlHeaderValue parsedValue))
-					{
-						HttpContext.Current.Response.CacheControl = parsedValue.ToString();
-					}
-					else
+					var Cache = _HttpContext.Response.Cache;
+					string[] values = value.Split(',');
+					foreach (string v in values)
 					{
-						var Cache = _HttpContext.Response.Cache;
-						string[] values = value.Split(',');
-						foreach (string v in values)
+						switch (v.Trim().ToUpper())
 						{
-							switch (v.Trim().ToUpper())
-							{
-								case "PUBLIC":
-									Cache.SetCacheability(HttpCacheability.Public);
-									break;
-								case "PRIVATE":
-									Cache.SetCacheability(HttpCacheability.Private);
-									break;
-								case "NO-CACHE":
-									Cache.SetCacheability(HttpCacheability.NoCache);
-									break;
-								case "NO-STORE":
-									Cache.AppendCacheExtension("no-store, must-revalidate");
-									break;
-								default:
-									GXLogging.Warn(log, String.Format("Could not set Cache Control Http Header Value '{0}' to HttpResponse", value));
-									break;
-							}
+							case "PUBLIC":
+								Cache.SetCacheability(HttpCacheability.Public);
+								break;
+							case "PRIVATE":
+								Cache.SetCacheability(HttpCacheability.Private);
+								break;
+							case "NO-CACHE":
+								Cache.SetCacheability(HttpCacheability.NoCache);
+								break;
+							case "NO-STORE":
+								Cache.AppendCacheExtension("no-store, must-revalidate");
+								break;
+							default:
+								GXLogging.Warn(log, String.Format("Could not set Cache Control Http Header Value '{0}' to HttpResponse", value));
+								break;
 						}
 					}
 				}
 				else if (name.Equals(HeaderNames.ContentType, StringComparison.OrdinalIgnoreCase))
 				{
 					_HttpContext.Response.ContentType = value;
 				}
+				else if (name.Equals(HeaderNames.Location, StringComparison.OrdinalIgnoreCase))
+				{
+					_HttpContext.Response.RedirectLocation = value;
+				}
 				else
 				{
-					if (!string.IsNullOrEmpty(_HttpContext.Response.Headers[name]))
+					try
 					{
 						_HttpContext.Response.Headers[name] = value;
-					}
-					else
+
+					}catch (PlatformNotSupportedException ex)
 					{
 						_HttpContext.Response.AppendHeader(name, value);
+						GXLogging.Warn(log, ex, "SetHeader ", name, value);
 					}
 				}
 #else
@@ -2510,10 +2507,12 @@ private void SetCustomHttpHeader(string name, string value)
 						_HttpContext.Response.AddHeader(name, value);
 				}
 #endif
+				return 0;
 			}
 			catch (Exception ex)
 			{
 				GXLogging.Error(log, ex, "Error adding header ", name, value);
+				return 1;
 			}
 		}
 

dotnet/test/DotNetUnitTest/Domain/GxHttpClientTest.cs

@@ -1,6 +1,12 @@
+using System.IO;
 using System.Net;
+using GeneXus.Application;
 using GeneXus.Http.Client;
 using Xunit;
+#if !NETCORE
+using System.Web.SessionState;
+using System.Web;
+#endif
 
 namespace xUnitTesting
 {
@@ -39,6 +45,20 @@ public void HttpClientInvalidURLWithCustomPort()
 				Assert.NotEqual(((int)HttpStatusCode.InternalServerError), httpclient.StatusCode);
 			}
 		}
+#if !NETCORE
+		[Fact]
+		public void NoStoreHeader()
+		{
+			var httpRequest = new HttpRequest("", "http://localhost/", "");
+			var httpResponce = new HttpResponse(new StringWriter());
+			var httpContext = new HttpContext(httpRequest, httpResponce);
+			HttpContext.Current = httpContext;
 
+			GxContext gxcontext = new GxContext();
+			gxcontext.HttpContext = HttpContext.Current;
+			byte result = gxcontext.SetHeader("CACHE", "no-store");
+			Assert.Equal(0, result);
+		}
+#endif
 	}
 }