Fix error with aspnet core compression on large response (#114)

Co-authored-by: claudia <cmurialdo@gmail.com>

Author: claudiamurialdo

dotnet/Directory.Build.props

@@ -6,7 +6,7 @@
 		<MinorFileVersion>5</MinorFileVersion>
 		<RevisionFileVersion Condition="'$(CommitNumber)'!=''">$(CommitNumber)</RevisionFileVersion>
 		<RevisionFileVersion Condition="'$(CommitNumber)'==''">0</RevisionFileVersion>
-		<FileVersionWithoutRevision>$(MajorFileVersion).$(MinorFileVersion).2</FileVersionWithoutRevision>
+		<FileVersionWithoutRevision>$(MajorFileVersion).$(MinorFileVersion).3</FileVersionWithoutRevision>
 		<FileVersion>$(FileVersionWithoutRevision).$(RevisionFileVersion)</FileVersion>
 		<InformationalVersion>$([System.DateTime]::UtcNow.ToString("yyyyMMddHHmmss")).$(GITHUB_SHA)</InformationalVersion>
 		<Company>GeneXus</Company>

dotnet/src/dotnetcore/GxClasses/Helpers/HtmlHelper.cs

@@ -19,7 +19,9 @@ public void Write(string s) {
 		}
 		public void Flush()
 		{
-			_context.Response.WriteAsync(_stream.ToString());
+			//Response.WriteAsync makes ResponseCompressor throws exception for big stream, use Response.Body.Write instead
+			_context.Response.Body.Write(Encoding.UTF8.GetBytes(_stream.ToString()));
+			_context.Response.Body.FlushAsync();
 		}
 	}
 

dotnet/src/dotnetcore/GxNetCoreStartup/Startup.cs

@@ -18,7 +18,6 @@
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.AspNetCore.ResponseCompression;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.AspNetCore.Server.Kestrel.Core;
 using Microsoft.AspNetCore.StaticFiles;
@@ -206,13 +205,14 @@ public void ConfigureServices(IServiceCollection services)
 				options.Cookie.HttpOnly = true;
 			});
 
-			services.Configure<GzipCompressionProviderOptions>(options => 
-			options.Level = System.IO.Compression.CompressionLevel.Fastest);
+
 			services.AddDirectoryBrowser();
-			services.AddResponseCompression(options =>
+			if (GXUtil.CompressResponse())
 			{
-				options.MimeTypes = new[]
+				services.AddResponseCompression(options =>
 				{
+					options.MimeTypes = new[]
+					{
 							// Default
 							"text/plain",
 							"text/css",
@@ -225,8 +225,10 @@ public void ConfigureServices(IServiceCollection services)
 							// Custom
 							"application/json",
 							"application/pdf"
-						};
-			});
+							};
+					options.EnableForHttps = true;
+				});
+			}
 			services.AddMvc();
 		}
 		public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
@@ -251,8 +253,10 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerF
 			provider.Mappings[".usdz"] = "model/vnd.pixar.usd";
 			provider.Mappings[".sfb"] = "model/sfb";
 			provider.Mappings[".gltf"] = "model/gltf+json";
-
-			app.UseResponseCompression();
+			if (GXUtil.CompressResponse())
+			{
+				app.UseResponseCompression();
+			}
 			app.UseCookiePolicy();
 			app.UseSession();
 			app.UseStaticFiles();