Fixed Code Correctness: Double-Checked Locking in various constructors (#781)

Issue: 105113

Author: tomas-sexenian

common/src/main/java/com/genexus/ApplicationContext.java

@@ -7,7 +7,7 @@
 
 public class ApplicationContext
 {
-	private static ApplicationContext instance;
+	private volatile static ApplicationContext instance;
 
 	private String  currentLocation = "";
 

common/src/main/java/com/genexus/BaseProvider.java

@@ -27,9 +27,9 @@ public abstract class BaseProvider implements IGXSmartCacheProvider
 	{
 		private static final ILogger logger = LogManager.getLogger(BaseProvider.class);
 
-		ConcurrentHashMap<String, Vector<String>> queryTables;	
+		volatile ConcurrentHashMap<String, Vector<String>> queryTables;
 		protected Date startupDate;
-		Object syncLock = new Object();
+		static Object syncLock = new Object();
 		protected static final String FORCED_INVALIDATE = "SD";
 
 

common/src/main/java/com/genexus/diagnostics/GXDebugManager.java

@@ -18,9 +18,9 @@ public class GXDebugManager
     static final int PGM_INFO_NO_PARENT = 0;
     private static final long MICRO_FREQ = 1000;
 
-    private static GXDebugManager instance;
+    private volatile static GXDebugManager instance;
     private static final Object sessionLock = new Object();
-    private static boolean initialized = false;
+    private volatile static boolean initialized = false;
     public static GXDebugManager getInstance()
     {
         if(!initialized)

common/src/main/java/com/genexus/util/PropertiesManager.java

@@ -11,7 +11,7 @@
 
 public final class PropertiesManager
 {
-	private static PropertiesManager instance;
+	private volatile static PropertiesManager instance;
 
 	private Hashtable propertyFiles;
 

java/src/main/java/com/genexus/internet/websocket/GXWebSocketService.java

@@ -23,7 +23,7 @@
 
 public class GXWebSocketService {
 	public static final ILogger logger = LogManager.getLogger(GXWebSocketService.class);
-	private static GXWebSocketService instance;
+	private volatile static GXWebSocketService instance;
 
 	private String[] handlerCache = new String[HandlerType.values().length];
 	private GXWebSocketSessionCollection wsClients = new GXWebSocketSessionCollection();

java/src/main/java/com/genexus/platform/NativeFunctions.java

@@ -4,7 +4,7 @@
 
 public class NativeFunctions
 {
-    private static INativeFunctions instance;
+    private volatile static INativeFunctions instance;
 
     private static Boolean isMicrosoft;
 

java/src/main/java/com/genexus/webpanels/BlobsCleaner.java

@@ -10,7 +10,7 @@
 
 public class BlobsCleaner
 {
-	private static BlobsCleaner instance = null;
+	private volatile static BlobsCleaner instance = null;
 
 	//Blobs archived by websession id
 	private Hashtable<String, ArrayList<String>> blobsTable;