Revert PR 276

Add Cache Control Headers for Angular Generator Rest Services

Author: iroqueta

common/src/main/java/com/genexus/ClientInformation.java

@@ -73,12 +73,4 @@ static public String getPlatformName()
 			platformName =  SpecificImplementation.Application.getModelContext().getHttpContext().getHeader("DevicePlatform");
 		return platformName;
 	}
-
-	public final class DeviceTypeEnum {
-		public static final int iOS = 0;
-		public static final int Android = 1;
-		public static final int Blackberry = 2;
-		public static final int Windows = 3;
-		public static final int Web = 4;
-	}
 }

common/src/main/java/com/genexus/GXSmartCacheProvider.java

@@ -63,7 +63,7 @@ public void discardUpdates()
 	// <param name="dateLastModified"></param>
 	// <param name="dateUpdated"></param>
 	// <returns>Unknown/Invalid/UpToDate</returns>
-	static public DataUpdateStatus checkDataStatus(String queryId, Date dateLastModified, Date[] dateUpdated_arr)
+	static public DataUpdateStatus CheckDataStatus(String queryId, Date dateLastModified, Date[] dateUpdated_arr)
 	{
 		return (DataUpdateStatus) provider.CheckDataStatus(queryId, dateLastModified, dateUpdated_arr);
 	}

java/src/main/java/com/genexus/GxRestService.java

@@ -244,58 +244,30 @@ public boolean processHeaders(String queryId, IHttpServletRequest myServletReque
 		{
 			setTheme(theme);
 		}
-		String eTag = isPostRequest(myServletRequest) ? null : myServletRequest.getHeader("If-Modified-Since");
+		String etag = myServletRequest.getMethod().equalsIgnoreCase(POST) ? null : myServletRequest.getHeader("If-Modified-Since");
 		Date dt = Application.getStartDateTime();
 		Date newDt = new Date();
 		GXSmartCacheProvider.DataUpdateStatus status;
 		Date[] newDt_arr = new Date[] { newDt };
-		if (eTag == null)
+		if (etag == null)
 		{
 			status = GXSmartCacheProvider.DataUpdateStatus.Invalid;
-			GXSmartCacheProvider.checkDataStatus(queryId, dt, newDt_arr);
+			GXSmartCacheProvider.CheckDataStatus(queryId, dt, newDt_arr);
 		}
 		else
 		{
-			dt = HTMLDateToDatetime(eTag);
-			status = GXSmartCacheProvider.checkDataStatus(queryId, dt, newDt_arr);
+			dt = HTMLDateToDatetime(etag);
+			status = GXSmartCacheProvider.CheckDataStatus(queryId, dt, newDt_arr);
 		}
 		newDt = newDt_arr[0];
-		addHeader(myServletResponse, "Last-Modified", DateTimeToHTMLDate(newDt));
-		addCacheHeaders(myServletResponse);
+		if (myServletResponse != null) // Temporary: Jersey Service called through AWS Lambda where HttpResponse is null.
+			myServletResponse.addHeader("Last-Modified", DateTimeToHTMLDate(newDt));
 		if (status == GXSmartCacheProvider.DataUpdateStatus.UpToDate)
 		{
 			return false;
 		}
 		return true;
 	}
-
-	private void addCacheHeaders(IHttpServletResponse myServletResponse) {
-		/*
-		 * https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
-		 * Specifying no-cache or max-age=0 indicates that
-		 * clients can cache a resource and must revalidate each time before using it.
-		 * This means HTTP request occurs each time, but it can skip downloading HTTP body if the content is valid.
-		 */
-		if (ClientInformation.getDeviceType() == ClientInformation.DeviceTypeEnum.Web) {
-			addHeader(myServletResponse, "Cache-Control", "no-cache, max-age=0");
-		}
-	}
-
-	boolean isPostRequest(IHttpServletRequest request)
-	{
-		return request.getMethod().equalsIgnoreCase(POST);
-	}
-
-	void addHeader(IHttpServletResponse response, String headerName, String headerValue)
-	{
-		if (response != null) {
-			// Temporary: Jersey Service called through AWS Lambda where HttpResponse is null.
-			response.addHeader(headerName, headerValue);
-		}
-		else {
-			logger.warn("Could add HttpHeader to Response");
-		}
-	}
 
 	Date HTMLDateToDatetime(String s)
 	{