hail_and_ride is not recognized as valid role for bus route

[mfrasca]

title says it all, I'm using the view public transport - routes to highlight whenever a route in my area becomes broken. unfortunately this works properly only for urban buses, where no section is "hail_and_ride". for rural bus routes, they all fail the role test.

if I understand the logic, we have two types of way members, one set where the roles would identify the way as a platform, one set where the roles would identify the way as a route section. as of now, members of this second set are only allowed the empty role, while I need 'hail_and_ride' to be accepted as well.

in this example area one route now correctly passes all tests, two more routes should pass all tests (now failing the unknown_role test), one route should fail the no_stops_pltf_at_begin test as it indeed does now.

[mfrasca]

I see that role checking for stops and platforms is done by means of two string comparison functions, while role checking for ways is just strcmp against the empty string.

possibly enough to replace the various comparisons !strcmp(x->role(), "") by an invocation is_way(x->role()) of the following function:

bool PTv2Checker::is_way(const char* role) {
    return !strcmp(role, "") || !strcmp(role, "hail_and_ride");
}

possibly like this, but you surely want unit tests …
my.patch.gz