Skip to content

Commit bf4be67

Browse files
committed
Refactor ColorRamp and mode components
1 parent da56e22 commit bf4be67

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

packages/base/src/dialogs/symbology/components/color_ramp/ColorRamp.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ const ColorRamp: React.FC<IColorRampProps> = ({
4545
const [isLoading, setIsLoading] = useState<boolean>(false);
4646

4747
useEffect(() => {
48-
if (selectedRamp === '') {
48+
if (
49+
selectedRamp === '' &&
50+
selectedMode === undefined &&
51+
numberOfShades === undefined
52+
) {
4953
populateOptions();
5054
}
5155
}, [layerParams]);
@@ -58,7 +62,7 @@ const ColorRamp: React.FC<IColorRampProps> = ({
5862
singleBandMode = layerParams.symbologyState.mode;
5963
colorRamp = layerParams.symbologyState.colorRamp;
6064
}
61-
setNumberOfShades(nClasses ? nClasses : '9');
65+
setNumberOfShades(nClasses ? nClasses : 9);
6266
setSelectedMode((singleBandMode as ClassificationMode) ?? 'equal interval');
6367
setSelectedRamp(colorRamp ? colorRamp : 'viridis');
6468
};

packages/base/src/dialogs/symbology/components/color_ramp/ModeSelectRow.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@ import React from 'react';
33
import { ClassificationMode } from '@/src/types';
44
interface IModeSelectRowProps {
55
numberOfShades: number | undefined;
6-
setNumberOfShades: (value: number | undefined) => void;
6+
setNumberOfShades: React.Dispatch<React.SetStateAction<number | undefined>>;
77
selectedMode: ClassificationMode | undefined;
8-
setSelectedMode: (value: ClassificationMode | undefined) => void;
8+
setSelectedMode: React.Dispatch<
9+
React.SetStateAction<ClassificationMode | undefined>
10+
>;
911
modeOptions: ClassificationMode[];
1012
}
1113
const ModeSelectRow: React.FC<IModeSelectRowProps> = ({

packages/base/src/dialogs/symbology/tiff_layer/types/SingleBandPseudoColor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const SingleBandPseudoColor: React.FC<ISymbologyDialogProps> = ({
4343
'continuous',
4444
'equal interval',
4545
'quantile',
46-
] as ClassificationMode[];
46+
] as const satisfies ClassificationMode[];
4747

4848
const stateDb = GlobalStateDbManager.getInstance().getStateDb();
4949

packages/base/src/dialogs/symbology/vector_layer/types/Graduated.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const Graduated: React.FC<ISymbologyTabbedDialogWithAttributesProps> = ({
3030
'jenks',
3131
'pretty',
3232
'logarithmic',
33-
] as ClassificationMode[];
33+
] as const satisfies ClassificationMode[];
3434

3535
const selectableAttributeRef = useRef<string>();
3636
const symbologyTabRef = useRef<string>();

0 commit comments

Comments
 (0)