diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 383bfb3c2..5cb7acb57 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -250,6 +250,9 @@ jobs: - name: Checkout uses: actions/checkout@v4 + - name: debug + run: ls + - name: Install Conda environment with Micromamba uses: mamba-org/setup-micromamba@v2 with: @@ -267,10 +270,7 @@ jobs: with: name: extension-artifacts - - name: debug - run: ls - - - name: Install the extension + - name: Install the extension artifacts shell: bash -l {0} run: | set -eux @@ -279,6 +279,7 @@ jobs: cp ./jupytergis_qgis/dist/jupytergis*.whl jupytergis_qgis-0.0.1-py3-none-any.whl cp ./jupytergis_lite/dist/jupytergis*.whl jupytergis_lite-0.0.1-py3-none-any.whl cp ./jupytergis/dist/jupytergis*.whl jupytergis-0.0.1-py3-none-any.whl + pip install ./jupytergis_core/dist/jupytergis*.whl ./jupytergis_lab/dist/jupytergis*.whl ./jupytergis_lite/dist/jupytergis*.whl ./jupytergis/dist/jupytergis*.whl - name: Build JupyterLite shell: bash -l {0} diff --git a/packages/base/src/tools.ts b/packages/base/src/tools.ts index 59aa534cd..2767c8ca7 100644 --- a/packages/base/src/tools.ts +++ b/packages/base/src/tools.ts @@ -394,13 +394,8 @@ const fetchWithProxies = async ( model: IJupyterGISModel, parseResponse: (response: Response) => Promise ): Promise => { - let settings: any = null; - try { - settings = await model.getSettings(); - } catch (e) { - console.warn('Failed to get settings from model. Falling back.', e); - } + const settings = await model.getSettings(); const proxyUrl = settings && settings.proxyUrl ? settings.proxyUrl : 'https://corsproxy.io'; diff --git a/python/jupytergis_core/src/jgisplugin/plugins.ts b/python/jupytergis_core/src/jgisplugin/plugins.ts index 3c3b54e54..cd96e320a 100644 --- a/python/jupytergis_core/src/jgisplugin/plugins.ts +++ b/python/jupytergis_core/src/jgisplugin/plugins.ts @@ -62,12 +62,8 @@ const activate = async ( let settings: ISettingRegistry.ISettings | null = null; - try { - settings = await settingRegistry.load(SETTINGS_ID); - console.log(`Loaded settings for ${SETTINGS_ID}`, settings); - } catch (error) { - console.warn(`Failed to load settings for ${SETTINGS_ID}`, error); - } + settings = await settingRegistry.load(SETTINGS_ID); + console.log(`Loaded settings for ${SETTINGS_ID}`, settings); const widgetFactory = new JupyterGISDocumentWidgetFactory({ name: FACTORY,