Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Commit 167d2ab

Browse files
authored
Add stylelint (#161)
* add stylelint package and config file * adds some rules for stylelint and styleline-scss * add prettier collision detection for stylelint + more rules, with list of stylelint-scss plugin rules * some more rulez * add max-nesting rule, disable stylelint in SideNav styles file because its a mess - to be resolved later * add new properties, refactor css in app and framework to correctly respect order rules from stylelint, greatly refactor form element scss to use shared mixin property helpers * add a lottttt more rules * Updates rule to not ignore background * add remaining stylelint rules * add default operators to new undernet config vars
1 parent da1c4ce commit 167d2ab

File tree

22 files changed

+1365
-291
lines changed

22 files changed

+1365
-291
lines changed

app/components/Footer/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@
1010
.has-feather {
1111
@include colored-link;
1212
display: inline-block;
13-
padding: 1rem;
13+
padding: $global-space;
1414
}
1515
}

app/components/GlobalNav/styles.scss

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
padding: 0;
1414
z-index: 5;
1515

16+
li {
17+
padding: 0;
18+
}
19+
1620
.nav-list {
1721
list-style-type: none;
1822
margin: 0;
@@ -41,23 +45,19 @@
4145
list-style-type: none;
4246
margin: 0;
4347
padding: 0;
48+
}
4449

45-
li {
46-
display: flex;
47-
align-items: center;
48-
}
50+
li {
51+
display: flex;
52+
align-items: center;
4953
}
5054
}
5155
}
5256

53-
li {
54-
padding: 0;
55-
}
56-
5757
li a {
5858
@include colored-link($white);
5959
display: flex;
6060
text-decoration: none;
61-
padding: 1rem;
61+
padding: $global-space;
6262
}
6363
}

app/components/SideNav/styles.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
@import "app/global";
22

3+
// stylelint-disable
4+
35
#side-nav {
46
background: #fbfbfb;
57

app/layouts/Main/prism.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ Prism template by Bram de Haan (http://atelierbram.github.io/syntax-highlighting
77
Original Base16 color scheme by Chris Kempson (https://github.com/chriskempson/base16)
88
99
*/
10+
11+
// stylelint-disable
12+
1013
code[class*="language-"],
1114
pre[class*="language-"] {
1215
font-family: Consolas, Menlo, Monaco, "Andale Mono WT", "Andale Mono", "Lucida Console",

app/pages/Docs/styles.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
.filler {
2121
background: $gray900;
2222
border-radius: $global-border-radius;
23-
margin-bottom: 1rem;
23+
margin-bottom: $global-space;
2424
}
2525

2626
.static-height {
@@ -63,13 +63,13 @@
6363

6464
.inverted-bg {
6565
background: $gray200;
66-
padding: 1rem 1rem 0 1rem;
66+
padding: $global-space $global-space 0 $global-space;
6767
}
6868

6969
.filler-bg {
7070
background: $gray900;
71-
padding: 1rem;
72-
margin-bottom: 1rem;
71+
padding: $global-space;
72+
margin-bottom: $global-space;
7373
border-radius: $global-border-radius;
7474

7575
.filler {

app/pages/Home/styles.scss

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,23 @@
1010
#home {
1111
width: 100%;
1212

13+
.animations {
14+
background-color: $brand-dark-blue;
15+
16+
.animated-icon {
17+
width: 125px;
18+
margin: 0 auto;
19+
}
20+
21+
p {
22+
margin: 0 8px;
23+
24+
@include breakpoint-down(large) {
25+
margin-bottom: 24px;
26+
}
27+
}
28+
}
29+
1330
.hero {
1431
background-image: url("../../assets/images/grid-bg.svg");
1532
background-repeat: no-repeat;
@@ -49,24 +66,7 @@
4966
}
5067
}
5168

52-
.animations {
53-
background-color: $brand-dark-blue;
54-
55-
.animated-icon {
56-
width: 125px;
57-
margin: 0 auto;
58-
}
59-
60-
p {
61-
margin: 0 8px;
62-
63-
@include breakpoint-down(large) {
64-
margin-bottom: 24px;
65-
}
66-
}
67-
}
68-
69-
a.has-gradient {
69+
.has-gradient {
7070
@include bg-gradient;
7171
border: none;
7272
padding: 14px 18px;

0 commit comments

Comments
 (0)