Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Commit f5725e2

Browse files
author
george
committed
updates header role and modernBrowser check in app initializer
1 parent 25ed13f commit f5725e2

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

app/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import "core-js/features/promise"
22

33
const polyfills = []
4-
const modernBrowser =
5-
"assign" in Object && typeof Promise === "function" && typeof Symbol === "function"
4+
const modernBrowser = "assign" in Object && "from" in Array && "fetch" in window
65

76
if (!modernBrowser) {
87
polyfills.push(import(/* webpackChunkName: "polyfill" */ "core-js/stable"))

app/layouts/Main/Main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export default class Main extends React.Component {
6565
tabIndex={headerTabIndex}
6666
ref={this.headerRef}
6767
onBlur={this.handleHeaderBlur}
68-
role="heading"
68+
role="banner"
6969
>
7070
<GlobalNav handleMainFocusClick={this.handleMainFocusClick} />
7171
</header>

app/layouts/Main/__tests__/__snapshots__/Main.spec.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ exports[`<Main /> #render renders 1`] = `
2727
<Main>
2828
<header
2929
onBlur={[Function]}
30-
role="heading"
30+
role="banner"
3131
tabIndex={null}
3232
>
3333
<GlobalNav

0 commit comments

Comments
 (0)