From 7a4dc3f7c8620accd0295712bccc92c460bfeb7d Mon Sep 17 00:00:00 2001
From: naveenkumar29052006 <nn03092005@gmail.com>
Date: Mon, 2 Feb 2026 15:47:27 +0530
Subject: [PATCH 1/2] add validation for WalletConnect connection strings

---
 .vscode/settings.json     |  5 ++++-
 src/nwc/NWCClient.test.ts | 19 +++++++++++++++++++
 src/nwc/NWCClient.ts      | 38 +++++++++++++++++++++++++++++++++++++-
 3 files changed, 60 insertions(+), 2 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index adbacfcb..c16685ca 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,5 +1,8 @@
 {
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "esbenp.prettier-vscode",
-  "prettier.trailingComma": "all"
+  "prettier.trailingComma": "all",
+  "[typescript]": {
+    "editor.defaultFormatter": "vscode.typescript-language-features"
+  }
 }
diff --git a/src/nwc/NWCClient.test.ts b/src/nwc/NWCClient.test.ts
index fa430cbe..c237d53c 100644
--- a/src/nwc/NWCClient.test.ts
+++ b/src/nwc/NWCClient.test.ts
@@ -51,6 +51,25 @@ describe("parseWalletConnectUrl", () => {
     ]);
   });
 });
+describe("parseWalletConnectUrl validation", () => {
+  test("throws when no relay is provided", () => {
+    expect(() =>
+      NWCClient.parseWalletConnectUrl(
+        "nostr+walletconnect://abc123",
+      ),
+    ).toThrow();
+  });
+
+  test("throws when secret is required but missing", () => {
+    expect(() =>
+      new NWCClient({
+        nostrWalletConnectUrl:
+          "nostr+walletconnect://abc123?relay=wss://relay.example.com",
+      }),
+    ).toThrow();
+  });
+});
+
 
 describe("NWCClient", () => {
   test("standard protocol", () => {
diff --git a/src/nwc/NWCClient.ts b/src/nwc/NWCClient.ts
index cc171ffa..a18668b8 100644
--- a/src/nwc/NWCClient.ts
+++ b/src/nwc/NWCClient.ts
@@ -81,6 +81,37 @@ export class NWCClient {
   options: NWCOptions;
   private _encryptionType: Nip47EncryptionType | undefined;
 
+
+
+
+  static validateWalletConnectUrl(
+    options: NWCOptions,
+    requireSecret = false,
+  ) {
+    if (!options.walletPubkey) {
+      throw new Error("Invalid WalletConnect URL: missing wallet pubkey");
+    }
+
+    if (!options.relayUrls || options.relayUrls.length === 0) {
+      throw new Error("Invalid WalletConnect URL: no relay URLs provided");
+    }
+
+    for (const relay of options.relayUrls) {
+      try {
+        new URL(relay);
+      } catch {
+        throw new Error(`Invalid relay URL: ${relay}`);
+      }
+    }
+
+    if (requireSecret && !options.secret) {
+      throw new Error(
+        "Invalid WalletConnect URL: missing secret parameter",
+      );
+    }
+  }
+
+
   static parseWalletConnectUrl(walletConnectUrl: string): NWCOptions {
     // makes it possible to parse with URL in the different environments (browser/node/...)
     // parses both new and legacy protocols, with or without "//"
@@ -107,13 +138,18 @@ export class NWCClient {
     if (lud16) {
       options.lud16 = lud16;
     }
+    NWCClient.validateWalletConnectUrl(options);
     return options;
   }
 
   constructor(options?: NewNWCClientOptions) {
     if (options && options.nostrWalletConnectUrl) {
+      const parsed = NWCClient.parseWalletConnectUrl(
+        options.nostrWalletConnectUrl,
+      );
+      NWCClient.validateWalletConnectUrl(parsed, true);
       options = {
-        ...NWCClient.parseWalletConnectUrl(options.nostrWalletConnectUrl),
+        ...parsed,
         ...options,
       };
     }

From 74c2878492750c4acfac5351d7e6298832c02388 Mon Sep 17 00:00:00 2001
From: Naveen Kumar <72962565+naveenkumar29052006@users.noreply.github.com>
Date: Mon, 2 Feb 2026 16:25:20 +0530
Subject: [PATCH 2/2] Remove TypeScript formatter settings from VSCode

---
 .vscode/settings.json | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index c16685ca..bd8fa271 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,8 +1,5 @@
 {
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "esbenp.prettier-vscode",
-  "prettier.trailingComma": "all",
-  "[typescript]": {
-    "editor.defaultFormatter": "vscode.typescript-language-features"
-  }
+   "prettier.trailingComma": "all"
 }