Roadmap & priorities

[DSanich]

@rolznz Hello!

I'm interested in your project and would be happy to contribute. Could you please let me know if there are any priority tasks you need help with? I'd be happy to take them on 🙏

[rolznz]

Hi @DSanich Please try out the app and provide feedback. That's the best way we can shape our roadmap.

You could tackle this one: #13

[DSanich]

@rolznz Yes, I have experience integrating AI-assistants to improve PR reviews. I'll write you some recommendations and help you with that. I also launched your app and didn't find any unit tests. I think this is useful, so I'm currently working on adding them. If you don't mind, I'll submit a PR for you once I'm done.

[rolznz]

@DSanich if you do unit tests, could you do a minimal example before a full blown PR? and would unit tests be as helpful as E2E tests?

[DSanich]

@rolznz Yes, of course, I'll try to push a small part to a separate branch and share a link with you so you can see what it looks like.

Regarding e2e tests, it's worth noting that they're not a replacement for unit tests, but a good extension of them. Unit tests are fast and don't overload the workflow, which will allow you to have a clear picture of the correctness of the created modules after publishing the PR. While e2e tests are important, they can be added in the future.

[DSanich]

@rolznz master...DSanich:getAlby-sandbox:feat/test-coverage-example I've pushed changes to this branch. You can see examples of unit test integration for all the main application modules: utils, types, stores, and scenarios. You can run them using yarn test. I'm continuing to work on full scenario coverage. If this proves useful, I'll publish a PR with full coverage once I'm done.

[rolznz]

@DSanich for this particular app I am not convinced unit tests will provide value. This is going to require a lot of maintenance and mocking the wallets in my opinion is not helpful. The scenarios won't work properly.

[DSanich]

@rolznz Would you prefer to use e2e tests first for the app?

[rolznz]

@DSanich after thinking about it, I think E2E tests in:

• Alby JS SDK <-- using https://faucet.nwc.dev
• Alby JS Lighting Tools <-- using faucet.nwc.dev
• Alby Hub <-- using https://faucet.mutinynet.com/

These projects power this sandbox and I think much more valuable to add testing there. There we have unit tests already (but also more unit tests would be great whereever you can see we need more coverage)

[DSanich]

@rolznz I've analyzed these three repositories. I'd like to point out that https://github.com/getAlby/hub/ has fairly good test coverage. I'd like to offer to help with expanding unit test coverage and integrating e2e tests into https://github.com/getAlby/js-sdk and https://github.com/getAlby/js-lightning-tools. I understand what you meant about the importance of improving testing for these repositories instead of the Sandbox application, as they are the source of its core business logic. I'd be happy to start by improving unit test coverage and integrating e2e tests into js-sdk, if that's okay.