Fixes behavior when no git initialized. #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczeles
reviewed
Oct 13, 2021
| @@ -93,7 +104,7 @@ def _create_template_stream( | |||
| image=image, | |||
| pipeline_name=context_helper.pipeline_name, | |||
| schedule_interval=schedule_interval, | |||
| git_info=context_helper.session.store["git"], | |||
| commit_sha=get_commit_sha(context_helper), | |||
There was a problem hiding this comment.
That is fantastic! But we still need git binary and .git folder inside docker image to log commit sha using kedro-mlflow, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DAG generation in non git repositories. You can specify commit id as
KEDRO_CONFIG_COMMIT_IDenv variable, otherwise it will try to take it from git and resolve to "UNKNOWN" if it's not possible.Resolves #110
Keep in mind: