add todos for event processors and integration hooks

Author: Lms24

packages/astro/src/server/sdk.ts

@@ -15,6 +15,7 @@ export function init(options: NodeOptions): NodeClient | undefined {
 
   const client = initNodeSdk(opts);
 
+  // TODO (span-streaming): remove this event processor. In this case, can probably just disable http integration server spans
   client?.addEventProcessor(
     Object.assign(
       (event: Event) => {

packages/browser/src/integrations/httpcontext.ts

@@ -8,6 +8,8 @@ import { getHttpRequestData, WINDOW } from '../helpers';
 export const httpContextIntegration = defineIntegration(() => {
   return {
     name: 'HttpContext',
+    // TODO (span-streaming): probably fine to omit this in favour of us globally
+    // already adding request context data but should double-check this
     preprocessEvent(event) {
       // if none of the information we want exists, don't bother
       if (!WINDOW.navigator && !WINDOW.location && !WINDOW.document) {

packages/browser/src/tracing/request.ts

@@ -156,6 +156,7 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
   if (traceFetch) {
     // Keeping track of http requests, whose body payloads resolved later than the initial resolved request
     // e.g. streaming using server sent events (SSE)
+    // TODO (span-streaming): replace with client hook - do we need client.on('processSpan')?
     client.addEventProcessor(event => {
       if (event.type === 'transaction' && event.spans) {
         event.spans.forEach(span => {

packages/core/src/integrations/eventFilters.ts

@@ -145,7 +145,7 @@ function _shouldDropEvent(event: Event, options: Partial<EventFiltersOptions>):
     }
   } else if (event.type === 'transaction') {
     // Filter transactions
-
+    // TODO (span-streaming): replace with ignoreSpans defaults (if we have any)
     if (_isIgnoredTransaction(event, options.ignoreTransactions)) {
       DEBUG_BUILD &&
         debug.warn(

packages/core/src/integrations/requestdata.ts

@@ -40,6 +40,8 @@ const _requestDataIntegration = ((options: RequestDataIntegrationOptions = {}) =
 
   return {
     name: INTEGRATION_NAME,
+    // TODO (span-streaming): probably fine to leave as-is for errors.
+    // For spans, we go through global context -> attribute conversion or omit this completely (TBD)
     processEvent(event, _hint, client) {
       const { sdkProcessingMetadata = {} } = event;
       const { normalizedRequest, ipAddress } = sdkProcessingMetadata;

packages/core/src/utils/featureFlags.ts

@@ -27,6 +27,7 @@ const SPAN_FLAG_ATTRIBUTE_PREFIX = 'flag.evaluation.';
 /**
  * Copies feature flags that are in current scope context to the event context
  */
+// TODO (span-streaming): should flags be added to (segment) spans? If so, probably do this via globally applying context data to spans
 export function _INTERNAL_copyFlagsFromScopeToEvent(event: Event): Event {
   const scope = getCurrentScope();
   const flagContext = scope.getScopeData().contexts.flags;

packages/core/src/utils/vercel-ai/index.ts

@@ -70,6 +70,7 @@ function onVercelAiSpanStart(span: Span): void {
   processGenerateSpan(span, name, attributes);
 }
 
+// TODO (span-streaming): move to client hook. What to do about parent modifications?
 function vercelAiEventProcessor(event: Event): Event {
   if (event.type === 'transaction' && event.spans) {
     // Map to accumulate token data by parent span ID

packages/deno/src/integrations/context.ts

@@ -56,6 +56,7 @@ const _denoContextIntegration = (() => {
   return {
     name: INTEGRATION_NAME,
     processEvent(event) {
+      // TODO (span-streaming): we probably need to apply this to spans via a hook IF we decide to apply contexts to (segment) spans
       return addDenoRuntimeContext(event);
     },
   };

packages/nextjs/src/client/index.ts

@@ -53,11 +53,13 @@ export function init(options: BrowserOptions): Client | undefined {
 
   const client = reactInit(opts);
 
+  // TODO (span-streaming): replace with ignoreSpans default?
   const filterTransactions: EventProcessor = event =>
     event.type === 'transaction' && event.transaction === '/404' ? null : event;
   filterTransactions.id = 'NextClient404Filter';
   addEventProcessor(filterTransactions);
 
+  // TODO (span-streaming): replace with ignoreSpans default?
   const filterIncompleteNavigationTransactions: EventProcessor = event =>
     event.type === 'transaction' && event.transaction === INCOMPLETE_APP_ROUTER_INSTRUMENTATION_TRANSACTION_NAME
       ? null

packages/nextjs/src/server/index.ts

@@ -223,6 +223,9 @@ export function init(options: NodeOptions): NodeClient | undefined {
     }
   });
 
+  // TODO (span-streaming):
+  //   - replace with ignoreSpans default
+  //   - allow ignoreSpans to filter on arbitrary span attributes (not just op)
   getGlobalScope().addEventProcessor(
     Object.assign(
       (event => {