Skip to content

Commit fcd5958

Browse files
committed
cleanup
1 parent 6933174 commit fcd5958

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

packages/browser/src/integrations/spanstreaming.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,9 @@ function applyCommonSpanAttributes(span: Span, serializedSegmentSpan: SpanV2JSON
225225
}
226226

227227
/**
228-
* Adds span attributes frome
228+
* Adds span attributes from the scopes' contexts
229+
* TODO: It's not set in stone yet if we actually want to flatmap contexts into span attributes.
230+
* For now we do it but not yet extra or tags. It's still TBD how to proceed here.
229231
*/
230232
function applyScopeToSegmentSpan(segmentSpan: Span, serializedSegmentSpan: SpanV2JSON, client: Client): void {
231233
const { isolationScope, scope } = getCapturedScopesOnSpan(segmentSpan);
@@ -237,8 +239,9 @@ function applyScopeToSegmentSpan(segmentSpan: Span, serializedSegmentSpan: SpanV
237239

238240
let contextAttributes = {};
239241
Object.keys(finalScopeData.contexts).forEach(key => {
240-
if (finalScopeData.contexts[key]) {
241-
contextAttributes = { ...contextAttributes, ...attributesFromObject(finalScopeData.contexts[key]) };
242+
const context = finalScopeData.contexts[key];
243+
if (context) {
244+
contextAttributes = { ...contextAttributes, ...attributesFromObject(context) };
242245
}
243246
});
244247

packages/core/src/types-hoist/options.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -306,14 +306,6 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
306306
* @returns A new metric that will be sent | null.
307307
*/
308308
beforeSendMetric?: (metric: Metric) => Metric | null;
309-
310-
/**
311-
* DO NOT set this option manually.
312-
*
313-
* @internal, this option is only used and set internally.
314-
* @hidden
315-
*/
316-
_INTERNAL_spanStreaming?: boolean;
317309
};
318310

319311
/**

0 commit comments

Comments
 (0)