Skip to content

test(browser-integration): Fix incorrect tag value assertions #18162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
+11 −3
Merged

test(browser-integration): Fix incorrect tag value assertions #18162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
840f39f
test(browser-integration): Fix incorrect tag value assertions
Lms24 Nov 11, 2025
d280f6b
found bug
Lms24 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dev-packages/browser-integration-tests/suites/public-api/setTag/with_non_primitives/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,19 @@ import type { Event } from '@sentry/core';
import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';

sentryTest('should not accept non-primitive tags', async ({ getLocalTestUrl, page }) => {
sentryTest('[bug] accepts non-primitive tags', async ({ getLocalTestUrl, page }) => {
// this is a bug that went unnoticed due to type definitions and a bad assertion
// TODO: We should not accept non-primitive tags. Fix this as a follow-up.
const url = await getLocalTestUrl({ testDir: __dirname });

const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);

expect(eventData.message).toBe('non_primitives');
expect(eventData.tags).toMatchObject({});

// TODO: This should be an empty object but instead, it is:
expect(eventData.tags).toEqual({
tag_1: {},
tag_2: [],
tag_3: ['a', {}],
});
});
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/public-api/setTag/with_primitives/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ sentryTest('should set primitive tags', async ({ getLocalTestUrl, page }) => {
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);

expect(eventData.message).toBe('primitive_tags');
expect(eventData.tags).toMatchObject({
expect(eventData.tags).toEqual({
tag_1: 'foo',
tag_2: 3.141592653589793,
tag_3: false,
Expand Down
Loading