Fix a possible bug that could make Sentry crash if an error is triggered before loading a console command

Author: Jean85

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
  - The `SentrySymfonyClient` is no longer an optional argument of `ExceptionListener`; it's now required
 ### Fixed
  - Remove usage of create_function to avoid deprecations (#71)
+ - Fix a possible bug that could make Sentry crash if an error is triggered before loading a console command
 ### Removed
  - Drop deprecated fields from configuration; the same options can be used (since 0.8.3) under `sentry.options`
  - Dropped the third argument from the `SentrySymfonyClient` constructor; `error_types` are now fetched from the second argument, the options array

src/EventListener/ExceptionListener.php

@@ -134,7 +134,7 @@ public function onConsoleException(ConsoleExceptionEvent $event)
 
         $data = [
             'tags' => [
-                'command' => $command->getName(),
+                'command' => $command ? $command->getName() : 'N/A',
                 'status_code' => $event->getExitCode(),
             ],
         ];

test/EventListener/ExceptionListenerTest.php

@@ -464,18 +464,13 @@ public function test_that_it_captures_exception()
         $listener->onKernelException($mockEvent);
     }
 
-    public function test_that_it_captures_console_exception()
+    /**
+     * @dataProvider mockCommandProvider
+     */
+    public function test_that_it_captures_console_exception(Command $mockCommand = null, $expectedCommandName)
     {
         $reportableException = new \Exception();
 
-        $mockCommand = $this->createMock(Command::class);
-
-        $mockCommand
-            ->expects($this->once())
-            ->method('getName')
-            ->willReturn('cmd name')
-        ;
-
         $mockEvent = $this->createMock(ConsoleExceptionEvent::class);
 
         $mockEvent
@@ -509,7 +504,7 @@ public function test_that_it_captures_console_exception()
                 $this->identicalTo($reportableException),
                 $this->identicalTo([
                     'tags' => [
-                        'command' => 'cmd name',
+                        'command' => $expectedCommandName,
                         'status_code' => 10,
                     ],
                 ])
@@ -521,6 +516,21 @@ public function test_that_it_captures_console_exception()
         $listener->onConsoleException($mockEvent);
     }
 
+    public function mockCommandProvider()
+    {
+        $mockCommand = $this->createMock(Command::class);
+        $mockCommand
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('cmd name')
+        ;
+
+        return [
+            [$mockCommand, 'cmd name'],
+            [null, 'N/A'], // the error may have been triggered before the command is loaded
+        ];
+    }
+
     public function test_that_it_can_replace_client()
     {
         $replacementClient = $this->createMock('Raven_Client');