fix: support named arguments in BufferFlushPass (#948)

Author: kk-daniel

src/DependencyInjection/Compiler/BufferFlushPass.php

@@ -45,8 +45,8 @@ private function findSentryBufferHandlers(ContainerBuilder $container): array
                 $arguments = $definition->getArguments();
                 if (!empty($arguments)) {
                     // The first argument of BufferHandler is the HandlerInterface, which
-                    // can be a SentryHandler.
-                    $firstArgument = $arguments[0];
+                    // can be a SentryHandler. Missing argument will be ignored.
+                    $firstArgument = $arguments[0] ?? $arguments['$handler'] ?? null;
 
                     if ($firstArgument instanceof Reference) {
                         $referencedServiceId = (string) $firstArgument;

tests/DependencyInjection/Compiler/BufferFlushPassTest.php

@@ -116,4 +116,21 @@ public function testProcessWithFakeSentryHandlers()
         $serviceIds = $this->argumentToName($definition);
         $this->assertEquals(['sentry.test.handler'], $serviceIds);
     }
+
+    /**
+     * Test that the flusher will work with named arguments.
+     *
+     * @return void
+     */
+    public function testProcessWithNamedArguments()
+    {
+        $container = new ContainerBuilder();
+        $container->setDefinition('sentry.handler', new Definition(SentryHandler::class));
+        $container->setDefinition('sentry.test.handler', new Definition(BufferHandler::class, ['$handler' => new Reference('sentry.handler')]));
+
+        (new BufferFlushPass())->process($container);
+        $definition = $container->getDefinition('sentry.buffer_flusher');
+        $serviceIds = $this->argumentToName($definition);
+        $this->assertEquals(['sentry.test.handler'], $serviceIds);
+    }
 }