Commit d921cc5
committed
Remove null checks around EventDispatcher
Originally the EventDispatcher was added with the intent that it could
be nullable, however a disconnect in how it was coded in the
ExceptionListener and how it was being injected left the code in a sort
of paradox with itself: we were always requiring it, but we were
null-checking it in the code as if it were possible to leave the
dispatcher null. Ultimately, after a few other changes and suggestions
from other participants in the code review it made the most sense just
to require the EventDispatcher and, within the code, make the
assumption that it would always be there rather than checking to see if
there was a null value.1 parent bc1648f commit d921cc5
1 file changed
+3
-7
lines changedLines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
114 | | - | |
| 112 | + | |
115 | 113 | | |
116 | 114 | | |
117 | 115 | | |
| |||
134 | 132 | | |
135 | 133 | | |
136 | 134 | | |
137 | | - | |
138 | | - | |
139 | | - | |
| 135 | + | |
140 | 136 | | |
141 | 137 | | |
142 | 138 | | |
| |||
0 commit comments