Skip to content

Commit 4b4a6b0

Browse files
authored
fix(ui): remove additional places where FrontendHeader gets rendered (#100948)
follow up to - #100915 which accidentally introduced duplicate tabs, as there are more places that weren’t accessible to me that also rendered the `<FrontendHeader>` and should’ve been removed in that PR. fixes: <img width="1367" height="358" alt="Screenshot 2025-10-06 at 09 41 13" src="https://github.com/user-attachments/assets/2cf628fa-b316-49d6-a134-b19c9504a9d4" />
1 parent 4f4db60 commit 4b4a6b0

File tree

3 files changed

+22
-31
lines changed

3 files changed

+22
-31
lines changed

static/app/views/insights/pages/frontend/am1OverviewPage.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ import * as ModuleLayout from 'sentry/views/insights/common/components/moduleLay
3333
import {ToolRibbon} from 'sentry/views/insights/common/components/ribbon';
3434
import {useOnboardingProject} from 'sentry/views/insights/common/queries/useOnboardingProject';
3535
import {OVERVIEW_PAGE_ALLOWED_OPS as BACKEND_OVERVIEW_PAGE_ALLOWED_OPS} from 'sentry/views/insights/pages/backend/settings';
36-
import {FrontendHeader} from 'sentry/views/insights/pages/frontend/frontendPageHeader';
3736
import {
38-
FRONTEND_LANDING_TITLE,
3937
FRONTEND_PLATFORMS,
4038
OVERVIEW_PAGE_ALLOWED_OPS,
4139
} from 'sentry/views/insights/pages/frontend/settings';
@@ -206,7 +204,6 @@ export function Am1FrontendOverviewPage() {
206204
organization={organization}
207205
renderDisabled={NoAccess}
208206
>
209-
<FrontendHeader headerTitle={FRONTEND_LANDING_TITLE} />
210207
<Layout.Body>
211208
<Layout.Main fullWidth>
212209
<ModuleLayout.Layout>

static/app/views/insights/pages/frontend/frontendOverviewPage.spec.tsx

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
22
import {PageFiltersFixture, PageFilterStateFixture} from 'sentry-fixture/pageFilters';
33
import {ProjectFixture} from 'sentry-fixture/project';
44

5-
import {render, screen} from 'sentry-test/reactTestingLibrary';
5+
import {render, waitFor} from 'sentry-test/reactTestingLibrary';
66

77
import ProjectsStore from 'sentry/stores/projectsStore';
88
import {useLocation} from 'sentry/utils/useLocation';
@@ -39,17 +39,16 @@ describe('FrontendOverviewPage', () => {
3939
it('fetches correct data with unknown + frontend platform', async () => {
4040
render(<FrontendOverviewPage />, {organization});
4141

42-
expect(await screen.findByRole('heading', {level: 1})).toHaveTextContent(
43-
'Frontend'
44-
);
45-
expect(mainTableApiCall).toHaveBeenCalledWith(
46-
'/organizations/org-slug/events/',
47-
expect.objectContaining({
48-
query: expect.objectContaining({
49-
query:
50-
'( ( transaction.op:pageload OR transaction.op:navigation OR transaction.op:ui.render OR transaction.op:interaction ) OR project.id:[1] ) !transaction.op:http.server event.type:transaction',
51-
}),
52-
})
42+
await waitFor(() =>
43+
expect(mainTableApiCall).toHaveBeenCalledWith(
44+
'/organizations/org-slug/events/',
45+
expect.objectContaining({
46+
query: expect.objectContaining({
47+
query:
48+
'( ( transaction.op:pageload OR transaction.op:navigation OR transaction.op:ui.render OR transaction.op:interaction ) OR project.id:[1] ) !transaction.op:http.server event.type:transaction',
49+
}),
50+
})
51+
)
5352
);
5453
});
5554

@@ -65,17 +64,16 @@ describe('FrontendOverviewPage', () => {
6564
);
6665
render(<FrontendOverviewPage />, {organization});
6766

68-
expect(await screen.findByRole('heading', {level: 1})).toHaveTextContent(
69-
'Frontend'
70-
);
71-
expect(mainTableApiCall).toHaveBeenCalledWith(
72-
'/organizations/org-slug/events/',
73-
expect.objectContaining({
74-
query: expect.objectContaining({
75-
query:
76-
'( ( transaction.op:pageload OR transaction.op:navigation OR transaction.op:ui.render OR transaction.op:interaction ) ) !transaction.op:http.server event.type:transaction',
77-
}),
78-
})
67+
await waitFor(() =>
68+
expect(mainTableApiCall).toHaveBeenCalledWith(
69+
'/organizations/org-slug/events/',
70+
expect.objectContaining({
71+
query: expect.objectContaining({
72+
query:
73+
'( ( transaction.op:pageload OR transaction.op:navigation OR transaction.op:ui.render OR transaction.op:interaction ) ) !transaction.op:http.server event.type:transaction',
74+
}),
75+
})
76+
)
7977
);
8078
});
8179
});

static/app/views/insights/pages/platform/shared/layout.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import {ToolRibbon} from 'sentry/views/insights/common/components/ribbon';
1616
import {useOnboardingProject} from 'sentry/views/insights/common/queries/useOnboardingProject';
1717
import {BackendHeader} from 'sentry/views/insights/pages/backend/backendPageHeader';
1818
import {BACKEND_LANDING_TITLE} from 'sentry/views/insights/pages/backend/settings';
19-
import {FrontendHeader} from 'sentry/views/insights/pages/frontend/frontendPageHeader';
20-
import {FRONTEND_LANDING_TITLE} from 'sentry/views/insights/pages/frontend/settings';
2119
import {useTransactionNameQuery} from 'sentry/views/insights/pages/platform/shared/useTransactionNameQuery';
2220
import {LegacyOnboarding} from 'sentry/views/performance/onboarding';
2321
import {getTransactionSearchQuery} from 'sentry/views/performance/utils';
@@ -60,9 +58,7 @@ export function PlatformLandingPageLayout({
6058
>
6159
{performanceType === 'backend' ? (
6260
<BackendHeader headerTitle={BACKEND_LANDING_TITLE} />
63-
) : (
64-
<FrontendHeader headerTitle={FRONTEND_LANDING_TITLE} />
65-
)}
61+
) : null}
6662
<Layout.Body>
6763
<Layout.Main fullWidth>
6864
<ModuleLayout.Layout>

0 commit comments

Comments
 (0)