add async deletion for deleting sentry app install directly

Author: cathteng

src/sentry/sentry_apps/api/endpoints/installation_details.py

@@ -4,12 +4,13 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, audit_log, deletions
+from sentry import analytics, audit_log
 from sentry.analytics.events.sentry_app_uninstalled import SentryAppUninstalledEvent
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import control_silo_endpoint
 from sentry.api.serializers import serialize
+from sentry.deletions.models.scheduleddeletion import ScheduledDeletion
 from sentry.sentry_apps.api.bases.sentryapps import SentryAppInstallationBaseEndpoint
 from sentry.sentry_apps.api.parsers.sentry_app_installation import SentryAppInstallationParser
 from sentry.sentry_apps.api.serializers.sentry_app_installation import (
@@ -56,7 +57,7 @@ def delete(self, request: Request, installation) -> Response:
             # if the error is from a request exception, log the error and continue
             except RequestException as exc:
                 sentry_sdk.capture_exception(exc)
-            deletions.exec_sync(sentry_app_installation)
+            ScheduledDeletion.schedule(sentry_app_installation, days=0, actor=request.user)
             create_audit_entry(
                 request=request,
                 organization_id=sentry_app_installation.organization_id,

tests/sentry/sentry_apps/api/endpoints/test_organization_sentry_app_installation_details.py

@@ -9,7 +9,9 @@
 )
 from sentry.analytics.events.sentry_app_uninstalled import SentryAppUninstalledEvent
 from sentry.constants import SentryAppInstallationStatus
+from sentry.deletions.tasks.scheduled import run_scheduled_deletions_control
 from sentry.models.auditlogentry import AuditLogEntry
+from sentry.sentry_apps.models.sentry_app_installation import SentryAppInstallation
 from sentry.sentry_apps.token_exchange.grant_exchanger import GrantExchanger
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.helpers.analytics import assert_last_analytics_event
@@ -120,6 +122,11 @@ def test_delete_install(self, record: MagicMock) -> None:
             ),
         )
 
+        with self.tasks():
+            run_scheduled_deletions_control()
+
+        assert not SentryAppInstallation.objects.filter(id=self.installation2.id).exists()
+
         response_body = json.loads(responses.calls[0].request.body)
 
         assert response_body.get("installation").get("uuid") == self.installation2.uuid