feat(issues): Remove router props from issue list (#100903)

Removes the deprecated router props and their corresponding types from
the issues list. They were mostly already unused.

part of getsentry/frontend-tsc#93

Author: scttcper

static/app/routes.tsx

@@ -2579,39 +2579,32 @@ function buildRoutes(): RouteObject[] {
     {
       index: true,
       component: errorHandler(OverviewWrapper),
-      deprecatedRouteProps: true,
     },
     {
       path: `${IssueTaxonomy.ERRORS_AND_OUTAGES}/`,
       component: make(() => import('sentry/views/issueList/pages/errorsOutages')),
-      deprecatedRouteProps: true,
     },
     {
       path: `${IssueTaxonomy.BREACHED_METRICS}/`,
       component: make(() => import('sentry/views/issueList/pages/breachedMetrics')),
-      deprecatedRouteProps: true,
     },
     {
       path: `${IssueTaxonomy.WARNINGS}/`,
       component: make(() => import('sentry/views/issueList/pages/warnings')),
-      deprecatedRouteProps: true,
     },
     {
       path: 'views/',
       component: make(
         () => import('sentry/views/issueList/issueViews/issueViewsList/issueViewsList')
       ),
-      deprecatedRouteProps: true,
     },
     {
       path: 'views/:viewId/',
       component: errorHandler(OverviewWrapper),
-      deprecatedRouteProps: true,
     },
     {
       path: 'searches/:searchId/',
       component: errorHandler(OverviewWrapper),
-      deprecatedRouteProps: true,
     },
     // Redirects for legacy tags route.
     {

static/app/views/issueList/overview.actions.spec.tsx

@@ -2,7 +2,6 @@ import {Fragment} from 'react';
 import {GroupFixture} from 'sentry-fixture/group';
 import {GroupStatsFixture} from 'sentry-fixture/groupStats';
 import {OrganizationFixture} from 'sentry-fixture/organization';
-import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
 
 import {
   render,
@@ -84,8 +83,6 @@ describe('IssueListOverview (actions)', () => {
     TagStore.init?.();
   });
 
-  const defaultProps = RouteComponentPropsFixture();
-
   describe('status', () => {
     const group1 = GroupFixture({
       id: '1',
@@ -123,7 +120,7 @@ describe('IssueListOverview (actions)', () => {
         method: 'PUT',
       });
 
-      render(<IssueListOverview {...defaultProps} />, {organization});
+      render(<IssueListOverview />, {organization});
 
       const groups = await screen.findAllByTestId('group');
 
@@ -161,7 +158,7 @@ describe('IssueListOverview (actions)', () => {
         method: 'PUT',
       });
 
-      render(<IssueListOverview {...defaultProps} />, {
+      render(<IssueListOverview />, {
         organization,
 
         initialRouterConfig: {
@@ -223,7 +220,7 @@ describe('IssueListOverview (actions)', () => {
 
       render(
         <Fragment>
-          <IssueListOverview {...defaultProps} />
+          <IssueListOverview />
           <Indicators />
         </Fragment>,
         {organization}
@@ -311,7 +308,7 @@ describe('IssueListOverview (actions)', () => {
         method: 'PUT',
       });
 
-      render(<IssueListOverview {...defaultProps} />, {
+      render(<IssueListOverview />, {
         organization,
 
         initialRouterConfig: {
@@ -387,7 +384,7 @@ describe('IssueListOverview (actions)', () => {
         method: 'PUT',
       });
 
-      render(<IssueListOverview {...defaultProps} />, {
+      render(<IssueListOverview />, {
         organization,
       });
 
@@ -430,7 +427,7 @@ describe('IssueListOverview (actions)', () => {
         method: 'PUT',
       });
 
-      render(<IssueListOverview {...defaultProps} />, {
+      render(<IssueListOverview />, {
         organization,
 
         initialRouterConfig: {
@@ -473,7 +470,7 @@ describe('IssueListOverview (actions)', () => {
         method: 'PUT',
       });
 
-      render(<IssueListOverview {...defaultProps} />, {
+      render(<IssueListOverview />, {
         organization,
 
         initialRouterConfig: {

static/app/views/issueList/overview.polling.spec.tsx

@@ -1,10 +1,9 @@
 import {GroupFixture} from 'sentry-fixture/group';
 import {GroupStatsFixture} from 'sentry-fixture/groupStats';
-import {LocationFixture} from 'sentry-fixture/locationFixture';
 import {MemberFixture} from 'sentry-fixture/member';
+import {ProjectFixture} from 'sentry-fixture/project';
 import {TagsFixture} from 'sentry-fixture/tags';
 
-import {initializeOrg} from 'sentry-test/initializeOrg';
 import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -38,26 +37,13 @@ describe('IssueList -> Polling', () => {
     MockApiClient.clearMockResponses();
   });
 
-  const {organization, project, routerProps} = initializeOrg({
-    organization: {
-      access: ['project:releases'],
-    },
-  });
+  const project = ProjectFixture();
   const group = GroupFixture({project});
   const group2 = GroupFixture({project, id: '2'});
 
-  const defaultProps = {
-    location: LocationFixture({
-      query: {query: 'is:unresolved'},
-      search: 'query=is:unresolved',
-    }),
-    params: {},
-    organization,
-  };
-
   /* helpers */
   const renderComponent = async () => {
-    render(<IssueList {...routerProps} {...defaultProps} />, {
+    render(<IssueList />, {
       initialRouterConfig: {
         location: {
           pathname: '/organizations/org-slug/issues/',