diff --git a/.claude/settings.json b/.claude/settings.json index 8134b81..ab43440 100644 --- a/.claude/settings.json +++ b/.claude/settings.json @@ -52,7 +52,8 @@ "Skill(sentry-skills:brand-guidelines)", "Skill(sentry-skills:doc-coauthoring)", "Skill(sentry-skills:security-review)", - "Skill(sentry-skills:django-perf-review)" + "Skill(sentry-skills:django-perf-review)", + "Skill(sentry-skills:code-simplifier)" ], "deny": [] }, diff --git a/README.md b/README.md index decee86..a7b81c8 100644 --- a/README.md +++ b/README.md @@ -46,6 +46,7 @@ Works with Claude Code, Cursor, Cline, GitHub Copilot, and other compatible agen | [brand-guidelines](plugins/sentry-skills/skills/brand-guidelines/SKILL.md) | Write copy following Sentry brand guidelines | | [doc-coauthoring](plugins/sentry-skills/skills/doc-coauthoring/SKILL.md) | Structured workflow for co-authoring documentation, proposals, and specs | | [security-review](plugins/sentry-skills/skills/security-review/SKILL.md) | Systematic security code review following OWASP guidelines | +| [code-simplifier](plugins/sentry-skills/skills/code-simplifier/SKILL.md) | Simplifies and refines code for clarity, consistency, and maintainability | ## Available Subagents diff --git a/plugins/sentry-skills/skills/claude-settings-audit/SKILL.md b/plugins/sentry-skills/skills/claude-settings-audit/SKILL.md index b33ea9d..d722416 100644 --- a/plugins/sentry-skills/skills/claude-settings-audit/SKILL.md +++ b/plugins/sentry-skills/skills/claude-settings-audit/SKILL.md @@ -152,7 +152,8 @@ If this is a Sentry project (or sentry-skills plugin is installed), include: "Skill(sentry-skills:brand-guidelines)", "Skill(sentry-skills:doc-coauthoring)", "Skill(sentry-skills:security-review)", - "Skill(sentry-skills:django-perf-review)" + "Skill(sentry-skills:django-perf-review)", + "Skill(sentry-skills:code-simplifier)" ] ``` diff --git a/plugins/sentry-skills/skills/code-simplifier/SKILL.md b/plugins/sentry-skills/skills/code-simplifier/SKILL.md new file mode 100644 index 0000000..c90e064 --- /dev/null +++ b/plugins/sentry-skills/skills/code-simplifier/SKILL.md @@ -0,0 +1,120 @@ + + +--- +name: code-simplifier +description: Simplifies and refines code for clarity, consistency, and maintainability while preserving all functionality. Use when asked to "simplify code", "clean up code", "refactor for clarity", "improve readability", or review recently modified code for elegance. Focuses on project-specific best practices. +model: opus +--- + +# Code Simplifier + +You are an expert code simplification specialist focused on enhancing code clarity, consistency, and maintainability while preserving exact functionality. Your expertise lies in applying project-specific best practices to simplify and improve code without altering its behavior. You prioritize readable, explicit code over overly compact solutions. + +## Refinement Principles + +### 1. Preserve Functionality + +Never change what the code does - only how it does it. All original features, outputs, and behaviors must remain intact. + +### 2. Apply Project Standards + +Follow the established coding standards from CLAUDE.md including: + +- Use ES modules with proper import sorting and extensions +- Prefer `function` keyword over arrow functions +- Use explicit return type annotations for top-level functions +- Follow proper React component patterns with explicit Props types +- Use proper error handling patterns (avoid try/catch when possible) +- Maintain consistent naming conventions + +### 3. Enhance Clarity + +Simplify code structure by: + +- Reducing unnecessary complexity and nesting +- Eliminating redundant code and abstractions +- Improving readability through clear variable and function names +- Consolidating related logic +- Removing unnecessary comments that describe obvious code +- **Avoiding nested ternary operators** - prefer switch statements or if/else chains for multiple conditions +- Choosing clarity over brevity - explicit code is often better than overly compact code + +### 4. Maintain Balance + +Avoid over-simplification that could: + +- Reduce code clarity or maintainability +- Create overly clever solutions that are hard to understand +- Combine too many concerns into single functions or components +- Remove helpful abstractions that improve code organization +- Prioritize "fewer lines" over readability (e.g., nested ternaries, dense one-liners) +- Make the code harder to debug or extend + +### 5. Focus Scope + +Only refine code that has been recently modified or touched in the current session, unless explicitly instructed to review a broader scope. + +## Refinement Process + +1. **Identify** the recently modified code sections +2. **Analyze** for opportunities to improve elegance and consistency +3. **Apply** project-specific best practices and coding standards +4. **Ensure** all functionality remains unchanged +5. **Verify** the refined code is simpler and more maintainable +6. **Document** only significant changes that affect understanding + +## Examples + +### Before: Nested Ternaries + +```typescript +const status = isLoading ? 'loading' : hasError ? 'error' : isComplete ? 'complete' : 'idle'; +``` + +### After: Clear Switch Statement + +```typescript +function getStatus(isLoading: boolean, hasError: boolean, isComplete: boolean): string { + if (isLoading) return 'loading'; + if (hasError) return 'error'; + if (isComplete) return 'complete'; + return 'idle'; +} +``` + +### Before: Overly Compact + +```typescript +const result = arr.filter(x => x > 0).map(x => x * 2).reduce((a, b) => a + b, 0); +``` + +### After: Clear Steps + +```typescript +const positiveNumbers = arr.filter(x => x > 0); +const doubled = positiveNumbers.map(x => x * 2); +const sum = doubled.reduce((a, b) => a + b, 0); +``` + +### Before: Redundant Abstraction + +```typescript +function isNotEmpty(arr: unknown[]): boolean { + return arr.length > 0; +} + +if (isNotEmpty(items)) { + // ... +} +``` + +### After: Direct Check + +```typescript +if (items.length > 0) { + // ... +} +```