From e896a70627a757cefea87f06880bb291761e3f08 Mon Sep 17 00:00:00 2001
From: David Cramer <dcramer@gmail.com>
Date: Tue, 3 Feb 2026 10:00:54 -0800
Subject: [PATCH] fix(iterate-pr): Handle workflow field as string from gh CLI

The gh pr checks --json workflow field returns a string, not an object.
The previous code assumed it was a dict with a "name" key, causing an
AttributeError when accessing .get("name") on a string.

Also update SKILL.md to use uv run instead of python directly, and add
skill design guideline to AGENTS.md for consistent script invocation.

Co-Authored-By: Claude <noreply@anthropic.com>
---
 AGENTS.md                                                     | 4 ++++
 plugins/sentry-skills/skills/iterate-pr/SKILL.md              | 4 ++--
 .../skills/iterate-pr/scripts/fetch_pr_checks.py              | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/AGENTS.md b/AGENTS.md
index c5fb526..22e79a9 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -51,6 +51,10 @@ license: LICENSE
 Instructions for the agent.
 ```
 
+## Skill Design Guidelines
+
+When writing skills that include Python scripts, always instruct the agent to use `uv run <script>` instead of `python <script>` or `python3 <script>`.
+
 ## References
 
 - [Agent Skills Spec](https://agentskills.io/specification)
diff --git a/plugins/sentry-skills/skills/iterate-pr/SKILL.md b/plugins/sentry-skills/skills/iterate-pr/SKILL.md
index a3db234..4f30d36 100644
--- a/plugins/sentry-skills/skills/iterate-pr/SKILL.md
+++ b/plugins/sentry-skills/skills/iterate-pr/SKILL.md
@@ -16,7 +16,7 @@ Continuously iterate on the current branch until all CI checks pass and review f
 Fetches CI check status and extracts failure snippets from logs.
 
 ```bash
-python scripts/fetch_pr_checks.py [--pr NUMBER]
+uv run scripts/fetch_pr_checks.py [--pr NUMBER]
 ```
 
 Returns JSON:
@@ -36,7 +36,7 @@ Returns JSON:
 Fetches and categorizes PR review feedback using the [LOGAF scale](https://develop.sentry.dev/engineering-practices/code-review/#logaf-scale).
 
 ```bash
-python scripts/fetch_pr_feedback.py [--pr NUMBER]
+uv run scripts/fetch_pr_feedback.py [--pr NUMBER]
 ```
 
 Returns JSON with feedback categorized as:
diff --git a/plugins/sentry-skills/skills/iterate-pr/scripts/fetch_pr_checks.py b/plugins/sentry-skills/skills/iterate-pr/scripts/fetch_pr_checks.py
index b6eac15..58d55cd 100755
--- a/plugins/sentry-skills/skills/iterate-pr/scripts/fetch_pr_checks.py
+++ b/plugins/sentry-skills/skills/iterate-pr/scripts/fetch_pr_checks.py
@@ -170,7 +170,7 @@ def main():
             "name": check.get("name", "unknown"),
             "status": check.get("bucket", check.get("state", "unknown")),
             "link": check.get("link", ""),
-            "workflow": check.get("workflow", {}).get("name", ""),
+            "workflow": check.get("workflow", ""),
         }
 
         # For failures, try to get log snippet