Rename push constants to immediates

Author: cwfitzgerald

benches/benches/wgpu-benchmark/computepass.rs

@@ -251,7 +251,7 @@ impl ComputepassState {
                 .create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                     label: None,
                     bind_group_layouts: &[&bind_group_layout],
-                    push_constant_ranges: &[],
+                    immediate_data_ranges: &[],
                 });
 
         let pipeline =
@@ -346,7 +346,7 @@ impl ComputepassState {
                     .create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                         label: None,
                         bind_group_layouts: &[&bindless_bind_group_layout],
-                        push_constant_ranges: &[],
+                        immediate_data_ranges: &[],
                     });
 
             let bindless_pipeline =

benches/benches/wgpu-benchmark/renderpass.rs

@@ -151,7 +151,7 @@ impl RenderpassState {
                 .create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                     label: None,
                     bind_group_layouts: &[&bind_group_layout],
-                    push_constant_ranges: &[],
+                    immediate_data_ranges: &[],
                 });
 
         let mut vertex_buffers = Vec::with_capacity(vertex_buffer_count as usize);
@@ -287,7 +287,7 @@ impl RenderpassState {
                     .create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                         label: None,
                         bind_group_layouts: &[&bindless_bind_group_layout],
-                        push_constant_ranges: &[],
+                        immediate_data_ranges: &[],
                     });
 
             bindless_pipeline = Some(device_state.device.create_render_pipeline(

deno_webgpu/device.rs

@@ -372,7 +372,7 @@ impl GPUDevice {
     let wgpu_descriptor = wgpu_core::binding_model::PipelineLayoutDescriptor {
       label: crate::transform_label(descriptor.label.clone()),
       bind_group_layouts: Cow::Owned(bind_group_layouts),
-      push_constant_ranges: Default::default(),
+      immediate_data_ranges: Default::default(),
     };
 
     let (id, err) = self.instance.device_create_pipeline_layout(

deno_webgpu/webidl.rs

@@ -430,8 +430,8 @@ pub enum GPUFeatureName {
   PartiallyBoundBindingArray,
   #[webidl(rename = "multi-draw-indirect-count")]
   MultiDrawIndirectCount,
-  #[webidl(rename = "push-constants")]
-  PushConstants,
+  #[webidl(rename = "immediate-data")]
+  ImmediateData,
   #[webidl(rename = "address-mode-clamp-to-zero")]
   AddressModeClampToZero,
   #[webidl(rename = "address-mode-clamp-to-border")]
@@ -500,7 +500,7 @@ pub fn feature_names_to_features(
       GPUFeatureName::UniformBufferBindingArrays => Features::UNIFORM_BUFFER_BINDING_ARRAYS,
       GPUFeatureName::PartiallyBoundBindingArray => Features::PARTIALLY_BOUND_BINDING_ARRAY,
       GPUFeatureName::MultiDrawIndirectCount => Features::MULTI_DRAW_INDIRECT_COUNT,
-      GPUFeatureName::PushConstants => Features::PUSH_CONSTANTS,
+      GPUFeatureName::ImmediateData => Features::IMMEDIATE_DATA,
       GPUFeatureName::AddressModeClampToZero => Features::ADDRESS_MODE_CLAMP_TO_ZERO,
       GPUFeatureName::AddressModeClampToBorder => Features::ADDRESS_MODE_CLAMP_TO_BORDER,
       GPUFeatureName::PolygonModeLine => Features::POLYGON_MODE_LINE,
@@ -631,8 +631,8 @@ pub fn features_to_feature_names(
   if features.contains(wgpu_types::Features::MULTI_DRAW_INDIRECT_COUNT) {
     return_features.insert(MultiDrawIndirectCount);
   }
-  if features.contains(wgpu_types::Features::PUSH_CONSTANTS) {
-    return_features.insert(PushConstants);
+  if features.contains(wgpu_types::Features::IMMEDIATE_DATA) {
+    return_features.insert(ImmediateData);
   }
   if features.contains(wgpu_types::Features::ADDRESS_MODE_CLAMP_TO_ZERO) {
     return_features.insert(AddressModeClampToZero);

examples/README.md

@@ -42,7 +42,7 @@ These examples use a common framework to handle wgpu init, window creation, and
 - `render_to_texture` - Renders to an image texture offscreen, demonstrating both off-screen rendering as well as how to add a sort of resolution-agnostic screenshot feature to an engine. This example either outputs an image file of your naming (pass command line arguments after specifying a `--` like `cargo run --bin wgpu-examples -- render_to_texture "test.png"`) or adds an `img` element containing the image to the page in WASM.
 - `ray_cube_fragment` - Demonstrates using ray queries with a fragment shader.
 - `ray_scene` - Demonstrates using ray queries and model loading
-- `ray_shadows` - Demonstrates a simple use of ray queries - high quality shadows - uses a light set with push constants to raytrace through an untransformed scene and detect whether there is something obstructing the light.
+- `ray_shadows` - Demonstrates a simple use of ray queries - high quality shadows - uses a light set with immediates to raytrace through an untransformed scene and detect whether there is something obstructing the light.
 - `mesh_shader` - Renders a triangle to a window with mesh shaders, while showcasing most mesh shader related features(task shaders, payloads, per primitive data).
 
 #### Compute

examples/features/src/big_compute_buffers/mod.rs

@@ -127,7 +127,7 @@ fn setup_pipeline(
     let pipeline_layout = device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
         label: Some("Compute Pipeline Layout"),
         bind_group_layouts: &[&bind_group_layout],
-        push_constant_ranges: &[],
+        immediate_data_ranges: &[],
     });
 
     device.create_compute_pipeline(&wgpu::ComputePipelineDescriptor {

examples/features/src/boids/mod.rs

@@ -107,7 +107,7 @@ impl crate::framework::Example for Example {
             device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                 label: Some("compute"),
                 bind_group_layouts: &[&compute_bind_group_layout],
-                push_constant_ranges: &[],
+                immediate_data_ranges: &[],
             });
 
         // create render pipeline with empty bind group layout
@@ -116,7 +116,7 @@ impl crate::framework::Example for Example {
             device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                 label: Some("render"),
                 bind_group_layouts: &[],
-                push_constant_ranges: &[],
+                immediate_data_ranges: &[],
             });
 
         let render_pipeline = device.create_render_pipeline(&wgpu::RenderPipelineDescriptor {

examples/features/src/bunnymark/mod.rs

@@ -201,7 +201,7 @@ impl crate::framework::Example for Example {
         let pipeline_layout = device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
             label: None,
             bind_group_layouts: &[&global_bind_group_layout, &local_bind_group_layout],
-            push_constant_ranges: &[],
+            immediate_data_ranges: &[],
         });
 
         let pipeline = device.create_render_pipeline(&wgpu::RenderPipelineDescriptor {

examples/features/src/conservative_raster/mod.rs

@@ -78,7 +78,7 @@ impl crate::framework::Example for Example {
             device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                 label: None,
                 bind_group_layouts: &[],
-                push_constant_ranges: &[],
+                immediate_data_ranges: &[],
             });
 
         let shader_triangle_and_lines =
@@ -195,7 +195,7 @@ impl crate::framework::Example for Example {
             let pipeline_layout = device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                 label: None,
                 bind_group_layouts: &[&bind_group_layout],
-                push_constant_ranges: &[],
+                immediate_data_ranges: &[],
             });
             let shader = device.create_shader_module(wgpu::include_wgsl!("upscale.wgsl"));
             (

examples/features/src/cube/mod.rs

@@ -158,7 +158,7 @@ impl crate::framework::Example for Example {
         let pipeline_layout = device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
             label: None,
             bind_group_layouts: &[&bind_group_layout],
-            push_constant_ranges: &[],
+            immediate_data_ranges: &[],
         });
 
         // Create the texture