refactor(gles): extract Buffer::{raw,data} into new enum BufferBacking
#8453
+178
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
gles-buffer-backing
branch
from
e9f273f to
96fb99a
Compare
cwfitzgerald
requested changes
Nov 12, 2025
Comment on lines
+294
to
+297
| let buffer = match &bar.buffer.backing { | ||
| &BufferBacking::Gl { raw } | &BufferBacking::GlCachedOnHost { raw, .. } => raw, | ||
| BufferBacking::Host { .. } => unreachable!(), | ||
| }; |
Member
There was a problem hiding this comment.
Suggested change
| let buffer = match &bar.buffer.backing { | |
| &BufferBacking::Gl { raw } | &BufferBacking::GlCachedOnHost { raw, .. } => raw, | |
| BufferBacking::Host { .. } => unreachable!(), | |
| }; | |
| let buffer = match bar.buffer.backing { | |
| BufferBacking::Gl { raw } | &BufferBacking::GlCachedOnHost { raw, .. } => raw, | |
| BufferBacking::Host { .. } => unreachable!(), | |
| }; |
This feels like a weird reference-dereference? If it needs a ref, could we use ref raw
Member
There was a problem hiding this comment.
Also in general I don't like taking references in match expressions, preferring to explictly using ref/ref mut. This is a slightly less conservative version of the clippy lint against match ergonomics.
| /// Storage backing a [`Buffer`]'s operations, possibly implemented with a host-side vector of | ||
| /// bytes. | ||
| /// | ||
| /// The [`Self::OnlyRaw`] variant is preferred, when supported. However, various workarounds for |
Member
There was a problem hiding this comment.
Out of date docs
Suggested change
| /// The [`Self::OnlyRaw`] variant is preferred, when supported. However, various workarounds for | |
| /// The [`Self::Gl`] variant is preferred, when supported. However, various workarounds for |
Comment on lines
+375
to
+381
| // #[derive(Clone, Debug)] | ||
| // enum MapState { | ||
| // Mapped { | ||
| // offset: Arc<MaybeMutex<wgt::BufferAddress>>, | ||
| // }, | ||
| // Unmapped, | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.