-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[wgsl in and IR] naga ray tracing pipelines #8570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Very exciting!! I will take a look sometime this week for sure! |
0b9dc42 to
bee83af
Compare
1d0dfca to
ee8883c
Compare
cwfitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Some small things then lets land and iterate, the tests look nice.
3c5a680 to
fc50128
Compare
|
Just going to note that spv-out is being worked on. Right now built-ins aren't yet supported, as I wanted to first implement traceRay (which is the most different part compared to everything else, the built-ins should just be mapping really). |
|
Lgtm in terms of RT pipelines 1.0/1.1, but we should keep in mind future support for SER hit objects (DX: https://github.com/microsoft/DirectX-Specs/blob/master/d3d/Raytracing.md#hitobject. VK: https://www.khronos.org/blog/boosting-ray-tracing-performance-with-shader-execution-reordering-introducing-vk-ext-ray-tracing-invocation-reorder). The main draw of RT pipelines for me is SER, so we should try and keep the API similar/transparent if we can. |
5bf4a3d to
ec1c25b
Compare
The API can't be transparent (without making many concessions), but changes for it should be limited to the trace ray calls (which even now reorder, just without any hints). |
Connections
Initial proposal for the wgsl front-end of #6760
Description
Adds wgsl-in and (partial) validation for the simplest version of ray tracing pipelines. This matches the spirv and hlsl specs to the best of my knowledge (though with less than complete validation). Things may change in the future though. @JMS55 may wish to check the naming ect. I don't normally open a naga PR w/o a full way through, but last time I tried pipelines I did that and struggled to keep it up to date.
Naming differences from vulkan
LaunchId->ray_invocation_id(I think its clearer what it is talking about)LaunchSize->num_ray_invocationsInstanceCustomIndex->instance_custom_data(like ray queries)RayTmax->ray_t_current_max(unlikeRayTmin, it changes over the life cycle of the ray, and doesn't match the field of the ray desc)Testing
Snapshot test from wgsl to IR.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.