Rename push constants to immediates #8586
Merged
+829
−837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/push-constants-to-immediates
branch
3 times, most recently
from
7059aa7 to
e162db9
Compare
teoxoy
reviewed
Nov 27, 2025
Member
|
I noticed "immediate data" is usually what this PR uses but I think the spec is moving in the direction of using "immediates" in most places. Thoughts on this? |
Member
Author
AHHHHHHHHHHHHHHHHHHHHHHHHHHH Updated |
cwfitzgerald
force-pushed
the
cw/push-constants-to-immediates
branch
from
e162db9 to
e788a64
Compare
cwfitzgerald
force-pushed
the
cw/push-constants-to-immediates
branch
from
e788a64 to
e3f9707
Compare
5 tasks
teoxoy
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Stage one of #8556
Description
This is the more annoying nuclear step of renaming push constants to immediate throughout the codebase. I have not changed the API at all, only done the renaming.
Testing
API
Squash or Rebase?
Squash