Skip to content

Commit 7f8ef50

Browse files
authored
clip: fix nb calculation for qwen3-vl (#17594)
1 parent 3c136b2 commit 7f8ef50

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

tools/mtmd/clip.cpp

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -987,12 +987,20 @@ struct clip_graph {
987987
cur = ggml_mul_mat(ctx0, layer.qkv_w, cur);
988988
cur = ggml_add(ctx0, cur, layer.qkv_b);
989989

990-
ggml_tensor * Qcur = ggml_view_3d(ctx0, cur, d_head, n_head, n_pos, d_head*sizeof(float),
991-
cur->nb[1], 0);
992-
ggml_tensor * Kcur = ggml_view_3d(ctx0, cur, d_head, n_head, n_pos, d_head*sizeof(float),
993-
cur->nb[1], n_embd * sizeof(float));
994-
ggml_tensor * Vcur = ggml_view_3d(ctx0, cur, d_head, n_head, n_pos, d_head*sizeof(float),
995-
cur->nb[1], 2 * n_embd * sizeof(float));
990+
ggml_tensor * Qcur = ggml_view_3d(ctx0, cur, d_head, n_head, n_pos,
991+
/* nb1 */ ggml_row_size(cur->type, d_head),
992+
/* nb2 */ cur->nb[1],
993+
/* offset */ 0);
994+
995+
ggml_tensor * Kcur = ggml_view_3d(ctx0, cur, d_head, n_head, n_pos,
996+
/* nb1 */ ggml_row_size(cur->type, d_head),
997+
/* nb2 */ cur->nb[1],
998+
/* offset */ ggml_row_size(cur->type, n_embd));
999+
1000+
ggml_tensor * Vcur = ggml_view_3d(ctx0, cur, d_head, n_head, n_pos,
1001+
/* nb1 */ ggml_row_size(cur->type, d_head),
1002+
/* nb2 */ cur->nb[1],
1003+
/* offset */ ggml_row_size(cur->type, 2 * n_embd));
9961004

9971005
cb(Qcur, "Qcur", il);
9981006
cb(Kcur, "Kcur", il);

0 commit comments

Comments
 (0)