HIP: enable WMMA-MMQ INT kernels for RDNA 3 #17576
Open
+100
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
| static constexpr int ne = I * J / 32; | ||
| #elif defined(RDNA3) | ||
| static constexpr int ne = (I == 16 && J == 16) ? I * J / 32 : I * J / 16; | ||
| #endif |
Collaborator
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // defined(RDNA4) |
Please add comments to indicate which #if/#ifdef and #endif is closing.
Comment on lines
+310
to
312
| if (GGML_CUDA_CC_IS_RDNA4(cc) || GGML_CUDA_CC_IS_RDNA3(cc)) { | ||
| return true; | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (GGML_CUDA_CC_IS_RDNA4(cc) || GGML_CUDA_CC_IS_RDNA3(cc)) { | |
| return true; | |
| } | |
| return true; |
Comment on lines
1545
to
+1548
| A1.x[0] = 0x01010101; | ||
| A1.x[1] = 0x01010101; | ||
| A1.x[2] = 0x01010101; | ||
| A1.x[3] = 0x01010101; |
Collaborator
There was a problem hiding this comment.
Suggested change
| A1.x[0] = 0x01010101; | |
| A1.x[1] = 0x01010101; | |
| A1.x[2] = 0x01010101; | |
| A1.x[3] = 0x01010101; | |
| #pragma unroll | |
| for (int l = 0; l < tile_A::ne; ++l) { | |
| A1.x[l] = 0x01010101; | |
| } |
To my understanding tile_A has 4 elements for RDNA3 but for RDNA4 it only has 2 elements. So as it is this would result in out-of-bounds writes and potential memory trampling for RDNA4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled WMMA-MMQ INT kernels for RDNA 3 architecture on AMD GPUs
Following similar approach to #17156
Using ./build/bin/llama-bench to collect the following performance results
Performance results with ggml/llama.cpp master commit up to/includes ab49f09
Build command for the following performance results:
HIPCXX="$(hipconfig -l)/clang" HIP_PATH="$(hipconfig -R)" cmake -S . -B build -DGGML_HIP=ON -DGGML_CUDA_FORCE_MMQ=OFF -DGGML_HIP_UMA=OFF -DGGML_HIP_ROCWMMA_FATTN=OFF -DGPU_TARGETS="gfx1100" -DGGML_HIP_GRAPHS=OFF -DLLAMA_CURL=OFF -DGGML_CUDA_FORCE_CUBLAS=OFF -DCMAKE_BUILD_TYPE=Release && cmake --build build --config Release -- -j 32