Skip to content

Commit 0b1aee3

Browse files
author
João Granado
authored
Merge pull request #19 from seegno-forks/bugfix/remove-event-listeners-on-unmount
Remove event listeners on unmounted components
2 parents 68f3ad3 + 1ee28b9 commit 0b1aee3

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/spark.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -302,18 +302,15 @@ function sparkFactory({animator, formulas, actionProps, setup, invalidateAutomat
302302
window.addEventListener('resize', onInvalidate, false);
303303
eventEmitter.on('invalidate', onInvalidate);
304304

305-
eventEmitter.once('cleanup', function() {
306-
window.removeEventListener('scroll', onScroll);
307-
window.removeEventListener('resize', onInvalidate);
308-
eventEmitter.removeListener('invalidate', onInvalidate)
309-
});
305+
spark.cleanup = () => {
306+
window.removeEventListener('scroll', onScroll);
307+
window.removeEventListener('resize', onInvalidate);
308+
eventEmitter.removeListener('invalidate', onInvalidate);
309+
};
310310

311311
// delay parse a frame to allow proxy to render
312312
animationFrame.request(parseData.bind(null,timeline));
313-
314313
};
315-
316-
spark.cleanup = () => eventEmitter.emit('cleanup');
317314

318315
spark.invalidate = () => eventEmitter.emit('invalidate');
319316

0 commit comments

Comments
 (0)