Skip to content

Commit 79f26d6

Browse files
edersonbrilhantegithub-actions[bot]npalm
authored
fix: remove invalid inputs for submodule direct (#4947)
When I was running terragrunt plan in my deployment I noticed this warning ``` 15:25:46.900 STDOUT tofu: │ 15:25:46.900 STDOUT tofu: │ on .terraform/modules/ec2_runners.runners/modules/webhook/webhook.tf line 59, in module "direct": 15:25:46.900 STDOUT tofu: │ 54: config = { 15:25:46.900 STDOUT tofu: │ 55: lambda_subnet_ids = var.lambda_subnet_ids, 15:25:46.901 STDOUT tofu: │ 56: lambda_security_group_ids = var.lambda_security_group_ids, 15:25:46.901 STDOUT tofu: │ 57: prefix = var.prefix, 15:25:46.901 STDOUT tofu: │ 58: tags = var.tags, 15:25:46.901 STDOUT tofu: │ 59: runner_matcher_config = var.runner_matcher_config, 15:25:46.901 STDOUT tofu: │ 60: sqs_job_queues_arns = [for k, v in var.runner_matcher_config : v.arn] 15:25:46.901 STDOUT tofu: │ 61: lambda_zip = var.lambda_zip, 15:25:46.901 STDOUT tofu: │ 62: lambda_memory_size = var.lambda_memory_size, 15:25:46.901 STDOUT tofu: │ 63: lambda_timeout = var.lambda_timeout, 15:25:46.901 STDOUT tofu: │ 64: role_permissions_boundary = var.role_permissions_boundary, 15:25:46.901 STDOUT tofu: │ 65: role_path = local.role_path, 15:25:46.901 STDOUT tofu: │ 66: logging_retention_in_days = var.logging_retention_in_days, 15:25:46.901 STDOUT tofu: │ 67: logging_kms_key_id = var.logging_kms_key_id, 15:25:46.901 STDOUT tofu: │ 68: lambda_s3_bucket = var.lambda_s3_bucket, 15:25:46.901 STDOUT tofu: │ 69: lambda_s3_key = var.webhook_lambda_s3_key, 15:25:46.901 STDOUT tofu: │ 70: lambda_s3_object_version = var.webhook_lambda_s3_object_version, 15:25:46.901 STDOUT tofu: │ 71: lambda_apigateway_access_log_settings = var.webhook_lambda_apigateway_access_log_settings, 15:25:46.901 STDOUT tofu: │ 72: repository_white_list = var.repository_white_list, 15:25:46.901 STDOUT tofu: │ 73: kms_key_arn = var.kms_key_arn, 15:25:46.902 STDOUT tofu: │ 74: log_level = var.log_level, 15:25:46.902 STDOUT tofu: │ 75: lambda_runtime = var.lambda_runtime, 15:25:46.902 STDOUT tofu: │ 76: aws_partition = var.aws_partition, 15:25:46.902 STDOUT tofu: │ 77: lambda_architecture = var.lambda_architecture, 15:25:46.902 STDOUT tofu: │ 78: github_app_parameters = var.github_app_parameters, 15:25:46.902 STDOUT tofu: │ 79: tracing_config = var.tracing_config, 15:25:46.902 STDOUT tofu: │ 80: lambda_tags = var.lambda_tags, 15:25:46.902 STDOUT tofu: │ 81: matcher_config_parameter_store_tier = var.matcher_config_parameter_store_tier, 15:25:46.902 STDOUT tofu: │ 82: api_gw_source_arn = "${aws_apigatewayv2_api.webhook.execution_arn}/*/*/${local.webhook_endpoint}" 15:25:46.902 STDOUT tofu: │ 83: ssm_parameter_runner_matcher_config = [ 15:25:46.902 STDOUT tofu: │ 84: for p in aws_ssm_parameter.runner_matcher_config : { 15:25:46.902 STDOUT tofu: │ 85: name = p.name 15:25:46.902 STDOUT tofu: │ 86: arn = p.arn 15:25:46.902 STDOUT tofu: │ 87: version = p.version 15:25:46.902 STDOUT tofu: │ 88: } 15:25:46.903 STDOUT tofu: │ 89: ] 15:25:46.903 STDOUT tofu: │ 90: } 15:25:46.903 STDOUT tofu: │ 15:25:46.903 STDOUT tofu: │ The object type for input variable "config" does not include an attribute 15:25:46.903 STDOUT tofu: │ named "runner_matcher_config", so this definition is unused. 15:25:46.903 STDOUT tofu: │ 15:25:46.903 STDOUT tofu: │ (and one more similar warning elsewhere) ``` This PR will remove invalid inputs when calling submodule direct in webhook --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
1 parent bf39fbc commit 79f26d6

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

modules/webhook/webhook.tf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ module "direct" {
5656
lambda_security_group_ids = var.lambda_security_group_ids,
5757
prefix = var.prefix,
5858
tags = var.tags,
59-
runner_matcher_config = var.runner_matcher_config,
6059
sqs_job_queues_arns = [for k, v in var.runner_matcher_config : v.arn]
6160
lambda_zip = var.lambda_zip,
6261
lambda_memory_size = var.lambda_memory_size,
@@ -78,7 +77,6 @@ module "direct" {
7877
github_app_parameters = var.github_app_parameters,
7978
tracing_config = var.tracing_config,
8079
lambda_tags = var.lambda_tags,
81-
matcher_config_parameter_store_tier = var.matcher_config_parameter_store_tier,
8280
api_gw_source_arn = "${aws_apigatewayv2_api.webhook.execution_arn}/*/*/${local.webhook_endpoint}"
8381
ssm_parameter_runner_matcher_config = [
8482
for p in aws_ssm_parameter.runner_matcher_config : {

0 commit comments

Comments
 (0)