Skip to content

Commit 52008ca

Browse files
committed
Add options to the listReleases function
1 parent 24223f7 commit 52008ca

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

lib/Repository.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -793,11 +793,12 @@ class Repository extends Requestable {
793793
/**
794794
* Get information about all releases
795795
* @see https://developer.github.com/v3/repos/releases/#list-releases-for-a-repository
796+
* @param {Object} options - pagination for the list
796797
* @param {Requestable.callback} cb - will receive the release information
797798
* @return {Promise} - the promise for the http request
798799
*/
799-
listReleases(cb) {
800-
return this._request('GET', `/repos/${this.__fullname}/releases`, null, cb);
800+
listReleases(options, cb = options) {
801+
return this._request('GET', `/repos/${this.__fullname}/releases`, options !== 'function' && options, cb);
801802
}
802803

803804
/**

test/repository.spec.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -628,6 +628,15 @@ describe('Repository', function() {
628628
});
629629

630630
it('should read all releases', function(done) {
631+
const paginationOptions = {
632+
per_page: 30
633+
};
634+
635+
remoteRepo.listReleases(paginationOptions, assertSuccessful(done, function(err, releases) {
636+
expect(releases).to.be.an.array();
637+
done();
638+
}));
639+
631640
remoteRepo.listReleases(assertSuccessful(done, function(err, releases) {
632641
expect(releases).to.be.an.array();
633642
done();

0 commit comments

Comments
 (0)