Fix push batches to 25 refspecs at once #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github#129 introduced this logic, however it created batches of 100 refspecs with overlaps between the pushes (0-100, 25-125 etc.) causing unnecessary duplication of work.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the batching logic for pushing Git refspecs where batches were incorrectly sized and overlapping. The fix changes the batch size calculation to properly create non-overlapping batches of 25 refspecs each.
- Corrects batch size calculation from 100 to 25 refspecs per batch
- Eliminates overlapping batches that caused duplicate work
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Author
|
Just noticed #147 on the same already, closing 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#129 introduced this logic, however it created batches of 100 refspecs with overlaps between the pushes (0-100, 25-125 etc.) causing unnecessary duplication of work.