Rule 7.0.1: Expand test case to cover non_compliant cases

For bool to class conversions.

Author: lcartey

cpp/misra/test/rules/RULE-7-0-1/NoConversionFromBool.expected

@@ -1,29 +1,33 @@
-| test.cpp:23:7:23:8 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:23:12:23:13 | b2 | Conversion from 'bool' to 'int'. |
 | test.cpp:25:7:25:8 | b1 | Conversion from 'bool' to 'int'. |
 | test.cpp:25:12:25:13 | b2 | Conversion from 'bool' to 'int'. |
 | test.cpp:27:7:27:8 | b1 | Conversion from 'bool' to 'int'. |
 | test.cpp:27:12:27:13 | b2 | Conversion from 'bool' to 'int'. |
-| test.cpp:29:8:29:9 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:33:7:33:8 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:33:12:33:13 | b2 | Conversion from 'bool' to 'int'. |
+| test.cpp:29:7:29:8 | b1 | Conversion from 'bool' to 'int'. |
+| test.cpp:29:12:29:13 | b2 | Conversion from 'bool' to 'int'. |
+| test.cpp:31:8:31:9 | b1 | Conversion from 'bool' to 'int'. |
 | test.cpp:35:7:35:8 | b1 | Conversion from 'bool' to 'int'. |
 | test.cpp:35:12:35:13 | b2 | Conversion from 'bool' to 'int'. |
 | test.cpp:37:7:37:8 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:37:13:37:14 | b2 | Conversion from 'bool' to 'int'. |
+| test.cpp:37:12:37:13 | b2 | Conversion from 'bool' to 'int'. |
 | test.cpp:39:7:39:8 | b1 | Conversion from 'bool' to 'int'. |
 | test.cpp:39:13:39:14 | b2 | Conversion from 'bool' to 'int'. |
-| test.cpp:43:7:43:8 | b1 | Conversion from 'bool' to 'int'. |
+| test.cpp:41:7:41:8 | b1 | Conversion from 'bool' to 'int'. |
+| test.cpp:41:13:41:14 | b2 | Conversion from 'bool' to 'int'. |
 | test.cpp:45:7:45:8 | b1 | Conversion from 'bool' to 'int'. |
 | test.cpp:47:7:47:8 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:51:20:51:21 | b1 | Conversion from 'bool' to 'double'. |
-| test.cpp:52:20:52:21 | b1 | Conversion from 'bool' to 'double'. |
-| test.cpp:53:28:53:29 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:56:34:56:35 | b1 | Conversion from 'bool' to 'int8_t'. |
-| test.cpp:57:36:57:37 | b1 | Conversion from 'bool' to 'int32_t'. |
-| test.cpp:60:6:60:7 | b1 | Conversion from 'bool' to 'int32_t'. |
-| test.cpp:61:6:61:7 | b1 | Conversion from 'bool' to 'double'. |
-| test.cpp:64:11:64:12 | b1 | Conversion from 'bool' to 'int'. |
-| test.cpp:72:9:72:10 | b1 | Conversion from 'bool' to 'int8_t'. |
-| test.cpp:73:10:73:11 | b1 | Conversion from 'bool' to 'int32_t'. |
-| test.cpp:74:8:74:9 | b1 | Conversion from 'bool' to 'double'. |
+| test.cpp:49:7:49:8 | b1 | Conversion from 'bool' to 'int'. |
+| test.cpp:53:20:53:21 | b1 | Conversion from 'bool' to 'double'. |
+| test.cpp:54:20:54:21 | b1 | Conversion from 'bool' to 'double'. |
+| test.cpp:55:28:55:29 | b1 | Conversion from 'bool' to 'int'. |
+| test.cpp:58:34:58:35 | b1 | Conversion from 'bool' to 'int8_t'. |
+| test.cpp:59:36:59:37 | b1 | Conversion from 'bool' to 'int32_t'. |
+| test.cpp:62:6:62:7 | b1 | Conversion from 'bool' to 'int32_t'. |
+| test.cpp:63:6:63:7 | b1 | Conversion from 'bool' to 'double'. |
+| test.cpp:66:11:66:12 | b1 | Conversion from 'bool' to 'int'. |
+| test.cpp:74:9:74:10 | b1 | Conversion from 'bool' to 'int8_t'. |
+| test.cpp:75:10:75:11 | b1 | Conversion from 'bool' to 'int32_t'. |
+| test.cpp:76:8:76:9 | b1 | Conversion from 'bool' to 'double'. |
+| test.cpp:113:33:113:36 | 1 | Conversion from 'bool' to 'A *'. |
+| test.cpp:116:8:116:11 | 1 | Conversion from 'bool' to 'int'. |
+| test.cpp:117:8:117:12 | 0 | Conversion from 'bool' to 'int'. |
+| test.cpp:118:25:118:28 | 1 | Conversion from 'bool' to 'int'. |

cpp/misra/test/rules/RULE-7-0-1/test.cpp

@@ -3,7 +3,9 @@
 struct A {
   explicit A(bool) {}
 };
-
+struct B {
+  B(int) {}
+};
 struct BitField {
   std::uint8_t bit : 1;
 };
@@ -105,12 +107,18 @@ void test_bool_conversion_compliant() {
   f1(b1 ? 1 : 0); // COMPLIANT
 
   // Explicit constructor calls - compliant
-  A l1{true};                  // COMPLIANT
-  A l2(false);                 // COMPLIANT
-  A l3 = static_cast<A>(true); // COMPLIANT
+  A l1{true};                          // COMPLIANT
+  A l2(false);                         // COMPLIANT
+  A l3 = static_cast<A>(true);         // COMPLIANT
+  A *l4 = reinterpret_cast<A *>(true); // NON_COMPLIANT - converted to integer
+                                       //                 then pointer, does not
+                                       //                 use constructor.
+  B l5{true};                          // NON_COMPLIANT
+  B l6(false);                         // NON_COMPLIANT
+  B l7 = static_cast<B>(true);         // NON_COMPLIANT
 
   // Assignment to constructor - compliant
-  A l4 = A{false}; // COMPLIANT
+  A l8 = A{false}; // COMPLIANT
 
   // Bit-field assignment exception - compliant
   bf.bit = b1; // COMPLIANT