Skip to content

Commit 98319ce

Browse files
asgerftausbn
andauthored
Apply suggestions from code review
Co-authored-by: Taus <tausbn@github.com>
1 parent d858384 commit 98319ce

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

javascript/ql/lib/semmle/javascript/internal/BindingInfo.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class TypeNameBindingNode extends NameResolution::Node {
2626
}
2727

2828
/**
29-
* Holds if this refers a value exported by the given module, with the given
29+
* Holds if this refers to a value exported by the given module, with the given
3030
* qualified name. If the `qualifiedName` is empty, this refers to the module itself.
3131
*
3232
* For example, the type annotations below have the following name bindings:
@@ -151,8 +151,8 @@ class ExprNameBindingNode extends NameResolution::Node {
151151
* ```ts
152152
* import * as f from "foo";
153153
*
154-
* var x = f; // hasQualifiedName(f, "")
155-
* var x = f.x.y; // hasQualifiedName(f, "x.y")
154+
* var x = f; // hasQualifiedName("f", "")
155+
* var x = f.x.y; // hasQualifiedName("f", "x.y")
156156
* ```
157157
*/
158158
predicate hasQualifiedName(string moduleName, string qualifiedName) {

javascript/ql/src/change-notes/2025-06-24-no-type-extraction-breaking.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
category: breaking
33
---
44
* The `Type` and `Symbol` classes have been deprecated and will be empty in newly extracted databases, since the TypeScript extractor no longer populates them.
5-
This is breaking change for custom queries that explicitly relied on these classes.
5+
This is a breaking change for custom queries that explicitly relied on these classes.
66
Such queries will still compile, but with deprecation warnings, and may have different query results due to type information no longer being available.
77
We expect most custom queries will not be affected, however. If a custom query has no deprecation warnings, it should not be affected by this change.
88
Uses of `getType()` should be rewritten to use the new `getTypeBinding()` or `getNameBinding()` APIs instead.

0 commit comments

Comments
 (0)