Skip to content

Commit aa02401

Browse files
committed
Address review comment
1 parent 06ba814 commit aa02401

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
557557
)
558558
or
559559
// flow into a callable
560-
fwdFlowInParam(_, node, _) and
560+
fwdFlowIn(_, _, _, node) and
561561
cc = true
562562
or
563563
// flow out of a callable
@@ -594,11 +594,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
594594
)
595595
}
596596

597-
pragma[nomagic]
598-
private predicate fwdFlowInParam(DataFlowCall call, ParamNodeEx p, Cc cc) {
599-
fwdFlowIn(call, _, cc, p)
600-
}
601-
602597
pragma[nomagic]
603598
private ReturnKindExtOption getDisallowedReturnKind(ParamNodeEx p) {
604599
if allowParameterReturnInSelfEx(p)
@@ -614,7 +609,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
614609
DataFlowCall call, ReturnKindExtOption disallowReturnKind, Cc cc
615610
) {
616611
exists(ParamNodeEx p |
617-
fwdFlowInParam(call, p, cc) and
612+
fwdFlowIn(call, _, cc, p) and
618613
disallowReturnKind = getDisallowedReturnKind(p)
619614
)
620615
}

0 commit comments

Comments
 (0)